Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version information for MaterialX dlls #1447

Conversation

ashwinbhat
Copy link
Contributor

No description provided.

Copy link
Member

@jstone-lucasfilm jstone-lucasfilm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a good change to me, thanks @ashwinbhat!

From the perspective of visual clarity, the one change that I would suggest is to add a newline after the initial set(MATERIALX_MODULE_NAME ...) at the beginning of each CMakeLists.txt file. This should help in setting this common setup apart from the module-specific logic that follows it in each file.

@jstone-lucasfilm jstone-lucasfilm merged commit 19eb023 into AcademySoftwareFoundation:main Aug 17, 2023
Michaelredaa pushed a commit to Michaelredaa/MaterialX that referenced this pull request Oct 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants