Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improvements to flattenSubgraphs #1101

Merged
merged 1 commit into from
Oct 10, 2022
Merged

Improvements to flattenSubgraphs #1101

merged 1 commit into from
Oct 10, 2022

Conversation

jstone-lucasfilm
Copy link
Member

  • Extend flattenSubgraphs to handle a broader range of graph structures, including references to interfaces with 'defaultgeomprop' strings.
  • Streamline the logic in flattenSubgraphs, merging duplicate code paths and clarifying documentation.
  • Add a 'Flatten Subgraphs' option to the MaterialX viewer, allowing render comparisons between nested and flattened graphs.

@jstone-lucasfilm
Improvements to flattenSubgraphs
930375a 
- Extend flattenSubgraphs to handle a broader range of graph structures, including references to interfaces with 'defaultgeomprop' strings.
- Streamline the logic in flattenSubgraphs, merging duplicate code paths and clarifying documentation.
- Add a 'Flatten Subgraphs' option to the MaterialX viewer, allowing render comparisons between nested and flattened graphs.
niklasharrysson
niklasharrysson approved these changes Oct 10, 2022
View reviewed changes
Copy link
Contributor

@niklasharrysson niklasharrysson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a great change!

@jstone-lucasfilm jstone-lucasfilm merged commit 7d4b758 into AcademySoftwareFoundation:main Oct 10, 2022
Michaelredaa pushed a commit to Michaelredaa/MaterialX that referenced this pull request Oct 21, 2023
@jstone-lucasfilm
Improvements to flattenSubgraphs (AcademySoftwareFoundation#1101)
e82d4df 
- Extend flattenSubgraphs to handle a broader range of graph structures, including references to interfaces with 'defaultgeomprop' strings.
- Streamline the logic in flattenSubgraphs, merging duplicate code paths and clarifying documentation.
- Add a 'Flatten Subgraphs' option to the MaterialX viewer, allowing render comparisons between nested and flattened graphs.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@niklasharrysson niklasharrysson niklasharrysson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jstone-lucasfilm @niklasharrysson