-
Notifications
You must be signed in to change notification settings - Fork 359
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extend mix node to allow per channel mixing #1077
Extend mix node to allow per channel mixing #1077
Conversation
|
mix
node to allow per channel mixingmix
node to allow per channel mixing
This proposal looks good to me, thanks @friedererdmann. I'm CC'ing @dbsmythe and @niklasharrysson for their thoughts. |
Looks good for GLSL and OSL. See attached renders from the testsuite. For MDL there is a small change needed, see above. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Thanks @friedererdmann
I've updated the v1.39 Spec document to mention support for per-channel operations: |
Thanks Niklas for your review and feedback! I don't seem to be able to merge myself, will you merge the PR? |
mix
node to allow per channel mixing…n#1077) The mix node's mix input should allow for all data formats as input and do a per element linear interpolation, not just float.
Extending
mix
node to allow per channel mixingThe mix node's mix input should allow for all data formats as input and do a per element linear interpolation, not just float. Example given:
For backwards compatibility float mixing remains supported.
Adding node definitions with the extra suffix of the mix data type like
ND_mix_color3_color3
.Note: So far I've only tested in MaterialX Viewer, I'm still working on some tests and will try to see results in other renderers.