From 6d672c62ed56c7ad056f90ded2fecfe4ca693067 Mon Sep 17 00:00:00 2001 From: vernalchen Date: Mon, 11 Jul 2022 16:04:55 +0800 Subject: [PATCH 1/5] Provide a frame transform for UV texture coordinates --- libraries/stdlib/stdlib_defs.mtlx | 15 ++++++++++ libraries/stdlib/stdlib_ng.mtlx | 30 +++++++++++++++++++ .../TestSuite/stdlib/math/transform.mtlx | 14 +++++++++ 3 files changed, 59 insertions(+) diff --git a/libraries/stdlib/stdlib_defs.mtlx b/libraries/stdlib/stdlib_defs.mtlx index f52ac0f300..326ded860e 100644 --- a/libraries/stdlib/stdlib_defs.mtlx +++ b/libraries/stdlib/stdlib_defs.mtlx @@ -2333,6 +2333,7 @@ @@ -2343,6 +2344,20 @@ + + + + + + + + + + @@ -1071,6 +1072,35 @@ + + + + + + + + + + + + + + + + + + + + + + + + + diff --git a/resources/Materials/TestSuite/stdlib/math/transform.mtlx b/resources/Materials/TestSuite/stdlib/math/transform.mtlx index 042f320c84..1fa31a5a50 100644 --- a/resources/Materials/TestSuite/stdlib/math/transform.mtlx +++ b/resources/Materials/TestSuite/stdlib/math/transform.mtlx @@ -178,4 +178,18 @@ + + + + + + + + + + + + + + From e356b7674aa7a413daf1b6daf0036235c6a67341 Mon Sep 17 00:00:00 2001 From: vernalchen Date: Wed, 13 Jul 2022 13:33:30 +0800 Subject: [PATCH 2/5] Refine wording & add test cases --- libraries/stdlib/stdlib_defs.mtlx | 17 +++------ libraries/stdlib/stdlib_ng.mtlx | 14 ++++---- .../stdlib/texture/image_transform.mtlx | 35 +++++++++++++++++++ 3 files changed, 48 insertions(+), 18 deletions(-) create mode 100644 resources/Materials/TestSuite/stdlib/texture/image_transform.mtlx diff --git a/libraries/stdlib/stdlib_defs.mtlx b/libraries/stdlib/stdlib_defs.mtlx index 326ded860e..1b64e2880d 100644 --- a/libraries/stdlib/stdlib_defs.mtlx +++ b/libraries/stdlib/stdlib_defs.mtlx @@ -2332,8 +2332,8 @@ @@ -2346,17 +2346,10 @@ - - - - - - - - + - + + @@ -1074,10 +1075,11 @@ - + + diff --git a/resources/Materials/TestSuite/stdlib/texture/image_transform.mtlx b/resources/Materials/TestSuite/stdlib/texture/image_transform.mtlx new file mode 100644 index 0000000000..33a78bca2e --- /dev/null +++ b/resources/Materials/TestSuite/stdlib/texture/image_transform.mtlx @@ -0,0 +1,35 @@ + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + From c8b2b3df3511932ff75d6b2aeab7c4f93194670f Mon Sep 17 00:00:00 2001 From: vernalchen Date: Tue, 26 Jul 2022 17:28:42 +0800 Subject: [PATCH 3/5] add the new funtionality into place2d --- libraries/stdlib/stdlib_defs.mtlx | 14 +++--- libraries/stdlib/stdlib_ng.mtlx | 44 ++++++++----------- .../TestSuite/stdlib/math/transform.mtlx | 15 +------ .../stdlib/texture/image_transform.mtlx | 10 +++-- 4 files changed, 32 insertions(+), 51 deletions(-) diff --git a/libraries/stdlib/stdlib_defs.mtlx b/libraries/stdlib/stdlib_defs.mtlx index 1b64e2880d..000344868c 100644 --- a/libraries/stdlib/stdlib_defs.mtlx +++ b/libraries/stdlib/stdlib_defs.mtlx @@ -2333,7 +2333,11 @@ @@ -2341,16 +2345,10 @@ + - - - - - + @@ -1070,37 +1073,28 @@ - - - - - - - - - - - + - - + + - - + + - - + + - + + + + + + diff --git a/resources/Materials/TestSuite/stdlib/math/transform.mtlx b/resources/Materials/TestSuite/stdlib/math/transform.mtlx index 1fa31a5a50..45ef4ee096 100644 --- a/resources/Materials/TestSuite/stdlib/math/transform.mtlx +++ b/resources/Materials/TestSuite/stdlib/math/transform.mtlx @@ -175,21 +175,8 @@ + - - - - - - - - - - - - - - diff --git a/resources/Materials/TestSuite/stdlib/texture/image_transform.mtlx b/resources/Materials/TestSuite/stdlib/texture/image_transform.mtlx index 33a78bca2e..939f053b3c 100644 --- a/resources/Materials/TestSuite/stdlib/texture/image_transform.mtlx +++ b/resources/Materials/TestSuite/stdlib/texture/image_transform.mtlx @@ -1,6 +1,6 @@ - + @@ -14,9 +14,10 @@ + - + @@ -24,12 +25,13 @@ - + - + + From 9d80a2f2dcfb4e8b08bad05dd5a1c310830df57a Mon Sep 17 00:00:00 2001 From: vernalchen Date: Wed, 27 Jul 2022 09:51:55 +0800 Subject: [PATCH 4/5] leverage the default value --- resources/Materials/TestSuite/stdlib/math/transform.mtlx | 1 - 1 file changed, 1 deletion(-) diff --git a/resources/Materials/TestSuite/stdlib/math/transform.mtlx b/resources/Materials/TestSuite/stdlib/math/transform.mtlx index 45ef4ee096..042f320c84 100644 --- a/resources/Materials/TestSuite/stdlib/math/transform.mtlx +++ b/resources/Materials/TestSuite/stdlib/math/transform.mtlx @@ -175,7 +175,6 @@ - From 8cac5aebb3d655e7c992d0704fb11ef2e606866a Mon Sep 17 00:00:00 2001 From: Jonathan Stone Date: Sun, 31 Jul 2022 13:40:07 -0700 Subject: [PATCH 5/5] Clarify node order in test material --- .../stdlib/texture/image_transform.mtlx | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/resources/Materials/TestSuite/stdlib/texture/image_transform.mtlx b/resources/Materials/TestSuite/stdlib/texture/image_transform.mtlx index 939f053b3c..a3afd60912 100644 --- a/resources/Materials/TestSuite/stdlib/texture/image_transform.mtlx +++ b/resources/Materials/TestSuite/stdlib/texture/image_transform.mtlx @@ -1,12 +1,6 @@ - - - - - - @@ -16,14 +10,14 @@ - - + + @@ -33,5 +27,11 @@ + + + + + +