Imath 3.1.1 MSVC build issues

[michdolan]

Imath 3.1.1
MSVC 14.2 x64 c++17

I was setting up a build with the above configuration on Windows 10 and ran into two minor build issues:

When building the Python bindings, I got several errors like:

...\imath-3.1.1\src\python\PyImath\PyImathStringTable.cpp(38,18): error C2039: 'domain_error': is not a member of 'std' [...\imath-3.1.1\src\python\PyImath\PyImath_Python3_7.vcxproj]

I resolved this by adding #include <stdexcept> to PyImathStringTable.cpp

The other issue may be more specific to my environment, but I will mention it just in case. When building with IMATH_HALF_USE_LOOKUP_TABLE=OFF I run into the following error:

...\Imath\half.h(329,14): error C3861: '__lzcnt': identifier not found [...\imath-3.1.1\src\Imath\Imath.vcxproj]

I resolved this error by specifying in CMAKE_CXX_FLAGS: /D__x86_64__=1 to force the inclusion of intrin.h in half.h, which was being bypassed otherwise.

Here's my configure and build commands:

cmake -D BUILD_TESTING=OFF -D BUILD_SHARED_LIBS=ON -D IMATH_HALF_USE_LOOKUP_TABLE=OFF -D PYTHON=ON -D Boost_ROOT=...\boost-1.76.0 -D CMAKE_CXX_FLAGS=/D__x86_64__=1 /EHsc -D CMAKE_CXX_STANDARD=17 -G Visual Studio 16 2019 -D CMAKE_BUILD_TYPE=Release -D CMAKE_POSITION_INDEPENDENT_CODE=ON -A x64 -D Python_ROOT_DIR=C:\Python37 -D PYTHON_EXECUTABLE=...\venv\Scripts\python.exe -D CMAKE_INSTALL_PREFIX=...\install\msvc142-x64-cxx17-release-py37\imath-3.1.1 -S ...\src\imath-3.1.1 -B ...\build\msvc142-x64-cxx17-release-py37\imath-3.1.1 -D Python3_ROOT_DIR=C:\Python37

cmake --build ...\build\msvc142-x64-cxx17-release-py37\imath-3.1.1 --target install --config Release --parallel 64

[meshula]

Adding that missing include would be a good PR.

Auto-detecting the need for the intrinsic include, in the header file, would be a good fix, rather than needing a command line argument.

[cary-ilm]

Closing this as I believe this was fixed by #215 and #190, let me know otherwise.