Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix install modules on subaccount #503

Merged

Conversation

Kayanski
Copy link
Contributor

@Kayanski Kayanski commented Oct 17, 2024

This PR aims at making sure that new modules are installed on an existing account with install_on_subaccount enabled.

For now, I just added a failing test

Checklist

  • CI is green.
  • Changelog updated.

Copy link

cloudflare-workers-and-pages bot commented Oct 17, 2024

Deploying abstract-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: 853a4ba
Status: ✅  Deploy successful!
Preview URL: https://babbd750.abstract-docs.pages.dev
Branch Preview URL: https://nicolas-abs-564-missing-modu.abstract-docs.pages.dev

View logs

@Kayanski Kayanski changed the title Added failing test Fix install modules on subaccount Oct 17, 2024
@Kayanski Kayanski marked this pull request as ready for review October 21, 2024 13:24
Copy link
Collaborator

@Buckram123 Buckram123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, good job! What do you think about returning result from the build_fn

Copy link
Collaborator

@Buckram123 Buckram123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small error handling comments

framework/packages/abstract-client/src/account.rs Outdated Show resolved Hide resolved
framework/packages/abstract-client/src/publisher.rs Outdated Show resolved Hide resolved
@Kayanski Kayanski merged commit 900e493 into main Oct 25, 2024
@Kayanski Kayanski deleted the nicolas/abs-564-missing-modules-function-has-a-weird-behavior-when branch October 25, 2024 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants