-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix install modules on subaccount #503
Merged
Kayanski
merged 13 commits into
main
from
nicolas/abs-564-missing-modules-function-has-a-weird-behavior-when
Oct 25, 2024
Merged
Fix install modules on subaccount #503
Kayanski
merged 13 commits into
main
from
nicolas/abs-564-missing-modules-function-has-a-weird-behavior-when
Oct 25, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying abstract-docs with Cloudflare Pages
|
…ng-modules-function-has-a-weird-behavior-when
Buckram123
approved these changes
Oct 21, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, good job! What do you think about returning result from the build_fn
CyberHoward
reviewed
Oct 23, 2024
…ng-modules-function-has-a-weird-behavior-when
Buckram123
approved these changes
Oct 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small error handling comments
Buckram123
reviewed
Oct 25, 2024
Kayanski
deleted the
nicolas/abs-564-missing-modules-function-has-a-weird-behavior-when
branch
October 25, 2024 12:46
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims at making sure that new modules are installed on an existing account with install_on_subaccount enabled.
For now, I just added a failing test
Checklist