You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
All dex/staking adapters need to implement the Default trait to be able to identify them. Shouldn't be add the Default trait as a requirement for the Identify trait?
The text was updated successfully, but these errors were encountered:
is because of IBC. if an action is performed "over IBC" then the adapter should return an ibc callback with that ID. At least that was the idea. I think the IBC aspect of these adapters needs a major revamp, but we can do that when we get there.
Here are some issues I have with the Dex Adapter
abstract/framework/packages/standards/dex/src/command.rs
Line 23 in 8882b7a
AnsAsset
andAssetEntry
when cw_asset usesAsset
andAssetInfo
. Shouldn't we use similare naming,AnsAsset
andAnsAssetInfo
?abstract/modules/contracts/adapters/dex/src/adapter.rs
Lines 41 to 50 in 8882b7a
Default
trait to be able to identify them. Shouldn't be add theDefault
trait as a requirement for theIdentify trait
?The text was updated successfully, but these errors were encountered: