Add comma as a valid separator for numeric values

[tr11]

This PR adds support for numeric values with comma as the decimal separator.

Fixes issue #240.

[yruslan]

Nice! Thanks for your contribution!

[yruslan]

@hamc17 , it seems CI does not trigger for PRs created by external contributors.

[a4032]

HI, the comma is indeed the most used decimal separator in west-europe. So If possible to fix this urgently? This is a blocking issue for us. Can you tell me when this will be available?
If not possible, we could not use cobrix maven library in our databricks solution.
thanks

[yruslan]

Hi, @a4032 ,
It is released as 2.0.2 already. It may take a couple of more hours to appear on Maven Central though,

[a4032]

unsuccessfully:

picture clause = PIC +9999999,99 USAGE DISPLAY.

installed library (maven) : za.co.absa.cobrix:spark-cobol_2.11:2.0.2

data = +0000100,00

after reading the file: the result = 'null'

when I use PIC X(11) it shows the correct value but is not numeric: '+0000100,00'

can you verify again please ?
thanks

[a4032]

Ye,s but I can installed it. So it is found in the maven library : [cid:[email protected]]

[yruslan]

I will take a look.

[yruslan]

The fix for the comma support has missed a fix for the decoder.
Currently, the fix is available in 2.0.3-SNAPSHOT. It will be in 2.0.3 after the fix is covered with a regression test.

[a4032]

Ok, keep me posted. And thanks for the effort

[tr11]

The fix for the comma support has missed a fix for the decoder.
Currently, the fix is available in 2.0.3-SNAPSHOT. It will be in 2.0.3 after the fix is covered with a regression test.

Oops, didn't even remember to check the decoder side. My bad, sorry!

[yruslan]

No worries. I should have checked it more thoroughly, but I'm ooo currently.

Thanks for the fix to the parser. It would have taken me much longer to figure it out.

[yruslan]

@a4032 , this should be fixed in 2.0.3.