Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

availableStyles is broken when using styleSheetSource from version >1.1 #39

Open
gck-ableton opened this issue Jan 26, 2016 · 0 comments
Open

availableStyles is broken when using styleSheetSource from version >1.1 #39

gck-ableton opened this issue Jan 26, 2016 · 0 comments

Comments

@gck-ableton
Copy link
Collaborator

The StyleEngine has some legacy code for supporting the old version 1.0 stylePath and styleName properties. When using the styleSheetSource property as a replacement, the availableStyles property is not working anymore.

Looking into the code this is obvious. mStylesDir is only set in setStylePath, but should of course be set from setStyleSheetSource, too. And btw, for the same reason stylePath seems to be equally "broken". styleName() is actually re-implemented in terms of mStyleSheetSourceUrl, but not stylePath.

Whatever. I think it's not worth trying to fix this. We should really drop 1.0-1.2 support soon.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@gck-ableton