Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Provider is required when unknown models are used" but no way to set provider for gpt-4-turbo. #560

Closed
CarlQLange opened this issue Apr 9, 2024 · 5 comments · Fixed by #562

Comments

@CarlQLange
Copy link

Annoyingly because of Textual I can't even see the full traceback - I can't find where the error text is even generated in Mentat or in Spice.

My mentat_config.json:

{
        "model": "gpt-4-turbo-preview",
        "maximum_context": 128000,
        "auto_context_tokens": 8000
}

Bit frustrating. Is there some way I should set this that I'm not seeing?

@CarlQLange
Copy link
Author

I got around this by monkeypatching https://github.com/AbanteAI/spice/blob/main/spice/models.py and adding a line for gpt-4-turbo

GPT_4_TURBO_PREVIEW = TextModel("gpt-4-turbo-preview", OPEN_AI, 128000)

@biobootloader
Copy link
Member

biobootloader commented Apr 10, 2024

Sorry about that! I've added gpt-4-turbo-preview and all the new OpenAI models from today to Spice and released a new version. Mentat isn't updated to use the new spice version yet though, I'm not sure if there are conflicts - @PCSwingle can you upgrade Mentat's spice dependency tomorrow, and also see if there's a way to get Textual to show more error details?

@CarlQLange
Copy link
Author

I think ideally this info would also be configurable and passed from the .mentatconfig.json as well!

@PCSwingle
Copy link
Member

Hey @CarlQLange! Just pushed a PR that fixes this and lets you set the provider via config. Thanks for catching this!

@CarlQLange
Copy link
Author

Thanks a bunch!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants