Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(filter): support filters on number fields #2308

Merged
merged 3 commits into from
Mar 20, 2024
Merged

fix(filter): support filters on number fields #2308

merged 3 commits into from
Mar 20, 2024

Conversation

sleidig
Copy link
Member

@sleidig sleidig commented Mar 19, 2024

fixes #1913

@github-actions GitHub Actions
Copy link
Contributor

Deployed to https://pr-2308.aam-digital.net/

@sleidig sleidig requested a review from tomwwinter March 19, 2024 17:10
tomwwinter
tomwwinter approved these changes Mar 20, 2024
View reviewed changes
Copy link
Contributor

@tomwwinter tomwwinter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

sleidig
sleidig commented Mar 20, 2024
View reviewed changes
Copy link
Member Author

@sleidig sleidig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

revert config changes

@sleidig sleidig merged commit 9303825 into master Mar 20, 2024
7 checks passed
@sleidig sleidig deleted the filter-number branch March 20, 2024 07:08
@aam-digital-ci
Copy link
Collaborator

🎉 This PR is included in version 3.34.0-master.3 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@aam-digital-ci aam-digital-ci added the released on @master managed by CI (semantic-release) label Mar 20, 2024
@aam-digital-ci
Copy link
Collaborator

🎉 This PR is included in version 3.34.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@aam-digital-ci aam-digital-ci added the released managed by CI (semantic-release) label Mar 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomwwinter tomwwinter tomwwinter approved these changes

Assignees
No one assigned
Labels
released on @master managed by CI (semantic-release) released managed by CI (semantic-release)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Number filters not working
3 participants
@sleidig @aam-digital-ci @tomwwinter