Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create new entity from entity-select fields in modal form #2293

Merged
merged 5 commits into from
Mar 15, 2024
Merged

Conversation

sleidig
Copy link
Member

@sleidig sleidig commented Mar 14, 2024

closes: #2213

Allow users to create new entity records from the entity-select field. At the moment only basic popup form supported, in the future this should be extended to the full details view in a modal.

This PR includes a small cleanup that should be merge separately in #2294

Copy link

Deployed to https://pr-2293.aam-digital.net/

@sleidig sleidig changed the base branch from master to user-refactor March 14, 2024 15:51
@sleidig sleidig requested a review from tomwwinter March 14, 2024 15:53
@sleidig sleidig changed the base branch from user-refactor to master March 14, 2024 15:54
@sleidig sleidig changed the base branch from master to user-refactor March 14, 2024 15:54
Base automatically changed from user-refactor to master March 15, 2024 08:57
Copy link
Contributor

@tomwwinter tomwwinter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sleidig sleidig merged commit f424d13 into master Mar 15, 2024
6 of 7 checks passed
@sleidig sleidig deleted the create-modal branch March 15, 2024 09:31
@aam-digital-ci
Copy link
Collaborator

🎉 This PR is included in version 3.34.0-master.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@aam-digital-ci aam-digital-ci added the released on @master managed by CI (semantic-release) label Mar 15, 2024
@aam-digital-ci
Copy link
Collaborator

🎉 This PR is included in version 3.34.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@aam-digital-ci aam-digital-ci added the released managed by CI (semantic-release) label Mar 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released on @master managed by CI (semantic-release) released managed by CI (semantic-release)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Creating new records from a entity select field
3 participants