Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid printed index of IndexParser #189

Closed
nus-pe-bot opened this issue Nov 1, 2019 · 2 comments
Closed

Invalid printed index of IndexParser #189

nus-pe-bot opened this issue Nov 1, 2019 · 2 comments
Assignees
Labels
type.Documentation A flaw in the documentation or change required

Comments

@nus-pe-bot
Copy link

Indexing is not intuitive for users.

called delete_task 1 but error message shows "invalid index. task with index 2 does not exist."

Screenshot 2019-11-01 at 14.37.38.png

This is especially confusing because your UG usually references the indexes starting from 1,2,3...
but your commands use the zero-based-indexing


[original: kwekke/ped#6]
@Kyzure Kyzure self-assigned this Nov 2, 2019
@Kyzure Kyzure added the type.Bug A bug. label Nov 2, 2019
@ghost ghost added the type.Documentation A flaw in the documentation or change required label Nov 2, 2019
This was referenced Nov 2, 2019
@ghost ghost changed the title Index for CRUD commands Invalid printed index of IndexParser Nov 2, 2019
@ghost
Copy link

ghost commented Nov 5, 2019

Fixed in #211, documentation should reflect that we use zero-based indexing.

@ghost ghost removed the type.Bug A bug. label Nov 5, 2019
@Kyzure Kyzure assigned Kyzure and unassigned Kyzure Nov 5, 2019
@Kyzure
Copy link

Kyzure commented Nov 5, 2019

Issue solved now error is also 0-based index. Added in documentation that it is zero-based indexing as well.

@Kyzure Kyzure closed this as completed Nov 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type.Documentation A flaw in the documentation or change required
Projects
None yet
Development

No branches or pull requests

2 participants