Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edit_event: 0 indexes given does not throw error #185

Closed
nus-pe-bot opened this issue Nov 1, 2019 · 2 comments
Closed

Edit_event: 0 indexes given does not throw error #185

nus-pe-bot opened this issue Nov 1, 2019 · 2 comments
Labels
type.Bug A bug.
Milestone

Comments

@nus-pe-bot
Copy link

Edit date
edit_event --end "19/11/2019 00:00"
Should not be a valid command. The toast at the top screen shows “Events edited: “
Even though it should not be a valid command as an index is not provided

edit_event 0 --end "19/11/2019 00:00"
Should not be a valid command. The event’s end date is still before the event’s start date. And should not be allowed to edit the task’s end date to be before the start date.

edit_event 0 --remind "18/11/2019 00:00"
Should not be a valid command. Reminder should not be after the event’s add date.

Screenshot 2019-11-01 at 16.57.37.png

doesn't make sense for end date to before start date
and reminder date to be after everything


[original: kwekke/ped#2]
@ghost ghost added the type.Bug A bug. label Nov 2, 2019
@ghost ghost self-assigned this Nov 2, 2019
@ghost
Copy link

ghost commented Nov 2, 2019

Issue with edit_event: No indexes should throw CommandException
Issue with EventSource: Should not allow creation of events with end/remind date before start date.

@ghost ghost added this to the v1.4 milestone Nov 2, 2019
@ghost ghost changed the title Edit date - date parsing Edit_event: 0 indexes given does not throw error Nov 2, 2019
@ghost
Copy link

ghost commented Nov 5, 2019

Fixed in #211, closing.

@ghost ghost closed this as completed Nov 5, 2019
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type.Bug A bug.
Projects
None yet
Development

No branches or pull requests

1 participant