Minor bug when running a Monte Carlo on a single process

[schaubh]

Hi there,

We've discovered a bug in BSK where, if running a single run Monte Carlo, the result of the run is not checked. Specifically, line 633 of Controller.py should check the result of that run and append it to the failed runs if there was a failure.

Here's an example fix with the "try/except/else" syntax, provided as a patch:

diff --git a/src/utilities/MonteCarlo/Controller.py b/src/utilities/MonteCarlo/Controller.py 
index 0d39f90b9..c208c4d21 100644 
--- a/src/utilities/MonteCarlo/Controller.py 
+++ b/src/utilities/MonteCarlo/Controller.py 
@@ -630,9 +630,12 @@ class Controller: 
                simGenerator = self.generateSims(list(range(i,i+1))) 
                for sim in simGenerator: 
                    try: 
-                        simulationExecutor([sim, self.dataOutQueue]) 
+                        run_ok = simulationExecutor([sim, self.dataOutQueue])[0] 
                    except: 
                        failed.append(i) 
+                    else: 
+                        if not run_ok: 
+                            failed.append(i) 
                    i += 1 
                    progressBar.update(i) 
        else:

Best,
Chris

[schaubh]

Howdy Chris, thanks for sharing this info. I'll take a look at this soon. I've not run this code since the upgrade to BSK2, so I appreciate your feedback.

Blue Skies, Hanspeter Schaub