From d21cc82b3e43afc3cad65c9d7db8c20c4a487c65 Mon Sep 17 00:00:00 2001 From: Jake Herrmann Date: Tue, 17 Dec 2024 12:14:55 -0900 Subject: [PATCH 1/2] do not suppress ruff failures --- .github/workflows/reusable-ruff.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/reusable-ruff.yml b/.github/workflows/reusable-ruff.yml index 25b7bd8..e5fcd7a 100644 --- a/.github/workflows/reusable-ruff.yml +++ b/.github/workflows/reusable-ruff.yml @@ -18,7 +18,7 @@ jobs: python -m pip install ruff - name: Ruff linting check - run: ruff check --output-format=github . || echo 'To automatically fix errors, run `ruff check --fix .`' + run: ruff check --output-format=github .; echo 'To automatically fix errors, run `ruff check --fix .`' - name: Ruff format check - run: ruff format --diff . || echo 'To automatically fix errors, run `ruff format .`' + run: ruff format --diff .; echo 'To automatically fix errors, run `ruff format .`' From b02bec1d36ee8c6ef3e112a60bd3944fa8ab22bc Mon Sep 17 00:00:00 2001 From: Jake Herrmann Date: Tue, 17 Dec 2024 12:20:20 -0900 Subject: [PATCH 2/2] changelog --- .github/workflows/reusable-ruff.yml | 6 ++++-- CHANGELOG.md | 5 +++++ 2 files changed, 9 insertions(+), 2 deletions(-) diff --git a/.github/workflows/reusable-ruff.yml b/.github/workflows/reusable-ruff.yml index e5fcd7a..fdf4216 100644 --- a/.github/workflows/reusable-ruff.yml +++ b/.github/workflows/reusable-ruff.yml @@ -18,7 +18,9 @@ jobs: python -m pip install ruff - name: Ruff linting check - run: ruff check --output-format=github .; echo 'To automatically fix errors, run `ruff check --fix .`' + # To automatically fix errors, run `ruff check --fix .` + run: ruff check --output-format=github . - name: Ruff format check - run: ruff format --diff .; echo 'To automatically fix errors, run `ruff format .`' + # To automatically fix errors, run `ruff format .` + run: ruff format --diff . diff --git a/CHANGELOG.md b/CHANGELOG.md index 91b8a7f..7b617d3 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -6,6 +6,11 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/), and this project adheres to [PEP 440](https://www.python.org/dev/peps/pep-0440/) and uses [Semantic Versioning](https://semver.org/spec/v2.0.0.html). +## [0.13.2] + +### Fixed +- Fix a bug in which [`reusable-ruff`](.github/workflows/reusable-ruff.yml) errors did not cause the action to fail. + ## [0.13.1] ### Changed