From b598aed27f63cc7da339323fc6fb8eb2684bc3a3 Mon Sep 17 00:00:00 2001 From: Mark Sujew Date: Tue, 9 Nov 2021 14:41:19 +0100 Subject: [PATCH] Always show plugin notification regardless of options (#10399) Fixes a bug introduced by #10245 which prevented plugin notifications from being shown --- packages/plugin-ext/src/plugin/message-registry.ts | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/packages/plugin-ext/src/plugin/message-registry.ts b/packages/plugin-ext/src/plugin/message-registry.ts index 395289a298fed..983f7cd6a8837 100644 --- a/packages/plugin-ext/src/plugin/message-registry.ts +++ b/packages/plugin-ext/src/plugin/message-registry.ts @@ -55,12 +55,11 @@ export class MessageRegistryExt { } } } - for (const item of rest) { - pushItem(item); - } - const actionHandle = await this.proxy.$showMessage(type, message, options, actions); - return actionHandle !== undefined ? items[actionHandle] : undefined; } - + for (const item of rest) { + pushItem(item); + } + const actionHandle = await this.proxy.$showMessage(type, message, options, actions); + return actionHandle !== undefined ? items[actionHandle] : undefined; } }