Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crypto: Update to Mbed Crypto 1.0.0d2 #9517

Closed
wants to merge 23 commits into from

Conversation

Patater
Copy link
Contributor

@Patater Patater commented Jan 28, 2019

Description

Update Mbed Crypto to development version mbedcrypto-1.0.0d2. This brings in changes necessary to adapt to the new PSA ITS API changes in #9192: both this PR and #9192 are mutually dependent and must be merged together.

This PR also depends on #9463 being merged first, to have the Mbed Crypto importer and file changes in place.

This PR starts from 413a6a0 ("crypto: Update to Mbed Crypto 1.0.0d2") and all other commits contained before that are from #9463, to be removed after #9463 is merged. The commits after are cherry-picked from #9192 so that #9192 wouldn't need to be merged separately (as that'd break without changes from Crypto to use the new ITS APIs).

Pull request type

[ ] Fix
[X] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@orenc17 @alzix

Patater and others added 7 commits January 23, 2019 11:59
Obtain the version of Mbed Crypto to use not from the Mbed TLS
submodule, but independently through the Mbed Crypto importer instead.
Use the Mbed-Crypto-specific importer script to re-import Mbed Crypto
0.1.0b2 to its new location.
Instead of doing a "pull --rebase" to update to the latest development
branch, do a "fetch" followed by a "checkout" to update to the specified
release. This enables us to get any new tags created since the last
update to the development branch, and removes the noise of updating a
local "development" branch.
Update tests in TESTS/mbed-crypto/sanity/main.cpp
Test key handles by adding a test to TESTS/mbed-crypto/sanity/main.cpp
@orenc17
Copy link
Contributor

orenc17 commented Jan 28, 2019

@Patater please rebase this on top of #9192 so we could run this in CI

@Patater
Copy link
Contributor Author

Patater commented Jan 28, 2019

Cherry-picked #9192 commits into this PR per @NirSonnenschein's recommendation at #9463 (comment)

@ciarmcom ciarmcom requested review from alzix, orenc17 and a team January 28, 2019 16:00
@ciarmcom ciarmcom requested review from a team January 28, 2019 16:00
@ciarmcom
Copy link
Member

@Patater, thank you for your changes.
@orenc17 @alzix @ARMmbed/mbed-os-core @ARMmbed/mbed-os-tools @ARMmbed/mbed-os-maintainers @ARMmbed/mbed-os-test @ARMmbed/mbed-os-crypto @ARMmbed/mbed-os-tls please review.

@mikisch81
Copy link
Contributor

@Patater looks like a merge conflict in target.json

@Patater
Copy link
Contributor Author

Patater commented Jan 29, 2019

Closing in favor of #9529

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants