-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Crypto: Update to Mbed Crypto 1.0.0d2 #9517
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Obtain the version of Mbed Crypto to use not from the Mbed TLS submodule, but independently through the Mbed Crypto importer instead.
Use the Mbed-Crypto-specific importer script to re-import Mbed Crypto 0.1.0b2 to its new location.
Instead of doing a "pull --rebase" to update to the latest development branch, do a "fetch" followed by a "checkout" to update to the specified release. This enables us to get any new tags created since the last update to the development branch, and removes the noise of updating a local "development" branch.
Update tests in TESTS/mbed-crypto/sanity/main.cpp
Test key handles by adding a test to TESTS/mbed-crypto/sanity/main.cpp
Only accessible from SPE
Cherry-picked #9192 commits into this PR per @NirSonnenschein's recommendation at #9463 (comment) |
@Patater looks like a merge conflict in |
Closing in favor of #9529 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update Mbed Crypto to development version mbedcrypto-1.0.0d2. This brings in changes necessary to adapt to the new PSA ITS API changes in #9192: both this PR and #9192 are mutually dependent and must be merged together.
This PR also depends on #9463 being merged first, to have the Mbed Crypto importer and file changes in place.
This PR starts from 413a6a0 ("crypto: Update to Mbed Crypto 1.0.0d2") and all other commits contained before that are from #9463, to be removed after #9463 is merged. The commits after are cherry-picked from #9192 so that #9192 wouldn't need to be merged separately (as that'd break without changes from Crypto to use the new ITS APIs).
Pull request type
Reviewers
@orenc17 @alzix