STM32: add information in README for SLEEP feature #14670
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ciarmcom
added
the
release-type: patch
|
@jeromecoutant, thank you for your changes. |
0xc0170
reviewed
May 18, 2021
targets/TARGET_STM/README.md
Outdated
|
|
||
| ST MCUs feature several low-power modes, please check Reference Manual of each one for more details. | ||
|
|
||
| - MBED sleep mode is usually mapped on ST SLEEP mode: |
There was a problem hiding this comment.
Suggested change
| - MBED sleep mode is usually mapped on ST SLEEP mode: | |
| - MBED sleep mode is usually mapped to ST SLEEP mode: |
targets/TARGET_STM/README.md
Outdated
| - all peripherals can run and wake up the CPU when an interrupt or an event | ||
| occurs | ||
|
|
||
| - MBED deepsleep mode is mapped on ST STOP2 mode: |
There was a problem hiding this comment.
Suggested change
| - MBED deepsleep mode is mapped on ST STOP2 mode: | |
| - MBED deepsleep mode is mapped to ST STOP2 mode: |
targets/TARGET_STM/README.md
Outdated
| - the LSI and the LSE can be kept running | ||
| - RTC can remain active | ||
|
|
||
| Reminder: related mbed-os is described there https://os.mbed.com/docs/mbed-os/latest/apis/power-management-sleep.html |
There was a problem hiding this comment.
This is rather a note or is it a reminider?
Detailed sleep Mbed OS description https://os.mbed.com/docs/mbed-os/latest/apis/power-management-sleep.html
jeromecoutant
force-pushed
the
PR_README_SLEEP
branch
from
aa72de0 to
afdc27a
Compare
|
@0xc0170 Thx for the review |
0xc0170
reviewed
May 19, 2021
| Detailed sleep Mbed OS description : https://os.mbed.com/docs/mbed-os/latest/apis/power-management-sleep.html | ||
| - debug profile is disabling deepsleep | ||
| - deepsleep can also be disabled by application or drivers using sleep_manager_lock_deep_sleep() | ||
| - deep-sleep-latency value is configured to 4 by default for STM32 |
There was a problem hiding this comment.
would it be worth documenting why 4 was selected here?
|
This pull request has automatically been marked as stale because it has had no recent activity. , please complete review of the changes to move the PR forward. Thank you for your contributions. |
|
@adbridge let's merge this doc update ? |
adbridge
approved these changes
Jun 4, 2021
|
CI started |
mbedmain
added
release-version: 6.12.0
Release-pending
and removed
release-type: patch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Few high level information added in the STM32 read me file about sleep and deepsleep feature implementation.
Part of #14610
Impact of changes
Migration actions required
Documentation
Pull request type
Test results
Reviewers