Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bare-metal configuration to support Pelion Device Management Client #11345

Merged
merged 2 commits into from
Aug 28, 2019
Merged

Fix bare-metal configuration to support Pelion Device Management Client #11345

merged 2 commits into from
Aug 28, 2019

Conversation

yogpan01
Copy link
Contributor

Description

This PR enables Pelion Device Management Client to adapt to bare metal configuration of mbed-os since Client uses nanostack event loop so this component must adhere to bare-metal configuration

Pull request type

[X] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@kjbracey-arm please review

Bare metal support for running PDMC
076deeb 
PDMC requires event loop to also support bare metal configuration.
It requires to adapt eventloop for bare-metal configuration.
@yogpan01
Copy link
Contributor Author

@kjbracey-arm please review.

@40Grit
Copy link

40Grit commented Aug 27, 2019

@trowbridgec

@0xc0170
Copy link
Contributor

0xc0170 commented Aug 27, 2019

CI started

@yogpan01
Copy link
Contributor Author

@0xc0170 This will be required for 5.14 release. Please add necessary labels.

@mbed-ci
Copy link

mbed-ci commented Aug 27, 2019

Test run: FAILED

Summary: 1 of 4 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_build-ARM

@0xc0170
Copy link
Contributor

0xc0170 commented Aug 27, 2019

Looks like ARM failed due to the changes here: [Error] @0,0: L6218E: Undefined symbol fhss_functions (referred from BUILD/tests/ARCH_MAX/ARM/features/nanostack/mbed-mesh-api/source/wisun_tasklet.o)

Fix to use correct build flag MBED_CONF_NANOSTACK_CONFIGURATION
6edab0e 
The bare-metal configuration should be using MBED_CONF_NANOSTACK_CONFIGURATION
instead of MBED_CONF_NANOSTACK_CONFIG.

Fixing the typo for flagging.
@yogpan01
Copy link
Contributor Author

@0xc0170 Fixed the failure build, should now build correctly for ARM toolchain as well.

@0xc0170
Copy link
Contributor

0xc0170 commented Aug 27, 2019

CI restarted

@mbed-ci
Copy link

mbed-ci commented Aug 27, 2019

Test run: FAILED

Summary: 1 of 4 test jobs failed
Build number : 2
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_build-IAR

@0xc0170
Copy link
Contributor

0xc0170 commented Aug 28, 2019

Error -11 from IAR, and ARM timeout, restarting to confirm (saw similar issue in another PR).

@mbed-ci
Copy link

mbed-ci commented Aug 28, 2019

Test run: FAILED

Summary: 2 of 4 test jobs failed
Build number : 3
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_build-ARM
  • jenkins-ci/mbed-os-ci_build-IAR

@yogpan01
Copy link
Contributor Author

@0xc0170 what is the failing cause now? I tried to read the artifact but couldnt decipher the reason for PR check failure.

@0xc0170
Copy link
Contributor

0xc0170 commented Aug 28, 2019

Ci restarted

It was the timeout , should be fixed in CI now (not related to this one).

@mbed-ci
Copy link

mbed-ci commented Aug 28, 2019

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 4
Build artifacts

@0xc0170 0xc0170 merged commit a6372e5 into ARMmbed:master Aug 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjbracey kjbracey kjbracey approved these changes

Assignees
No one assigned
Labels
release-version: 5.14.0-rc1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@yogpan01 @40Grit @0xc0170 @mbed-ci @kjbracey