Nanostack 802.15.4 RF drivers update #10185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artokin
force-pushed
the
mcr20a_interruptin_flag_fix
branch
from
df8b60f to
e283db6
Compare
JarkkoPaso
approved these changes
Mar 21, 2019
|
@artokin, thank you for your changes. |
SeppoTakalo
approved these changes
Mar 21, 2019
|
I'm starting to wonder whether the Driver header file should produce "#error Unsupported platform" or something similar. Now this flagging just leads to very weird build errors on platforms that cannot use the driver. However, I'm not proposing changes to this PR. Just stating the fact that this if-deffing is not very elegant solution. |
jeromecoutant
suggested changes
Mar 21, 2019
Sync Nanostack RF drivers from master copy: -MCR20A: v1.0.6 -S2LP: v0.0.5
artokin
force-pushed
the
mcr20a_interruptin_flag_fix
branch
from
e283db6 to
0710298
Compare
|
@jeromecoutant , MCR20Drv.c is now flagged, would you please try building again? |
jeromecoutant
approved these changes
Mar 22, 2019
|
CI started |
Test run: SUCCESSSummary: 13 of 13 test jobs passed |
cmonr
approved these changes
Mar 26, 2019
cmonr
pushed a commit
to cmonr/mbed-os
that referenced
this pull request
Mar 26, 2019
…_fix Nanostack 802.15.4 RF drivers update
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Sync Nanostack RF drivers from master copy:
-MCR20A: v1.0.5
A Fix to DEVICE_INTERRUPTIN flagging made in #10142
Pull request type
Reviewers
@JarkkoPaso