Skip to content
This repository has been archived by the owner on Apr 24, 2019. It is now read-only.

Realtek RTL8195AM support #343

Merged
merged 2 commits into from
Dec 9, 2017
Merged

Realtek RTL8195AM support #343

merged 2 commits into from
Dec 9, 2017

Conversation

JanneKiiskila
Copy link
Contributor

@JanneKiiskila JanneKiiskila commented Dec 7, 2017 •
edited
Loading

Support for compiling against Realtek RTL8195AM. Please note there
are some limitations:

  • The board does not have any LEDs connected to the main cpu, therefore
    LED blinking will not work unless you connect an external LED.
  • Buttons are not connected either.
  • The client will crash after a while with
    CMSIS-RTOS error: ISR Queue overflow (status: 0x2, task ID: 0x0, object ID: 0x3006146C)
    issue has been raised to Mbed OS on this.
    Issues are documented in the README.md changes.

Status

READY

Migrations

NO

Realtek RTL8195AM support
700d016 
Support for compiling against Realtek RTL8195AM. Please note there
are some limitations:
- the board does not have any LEDs connected to the main cpu, therefore
  LED blinking will not work unless you connect an external LED.
- the client will crash after a while with
  CMSIS-RTOS error: ISR Queue overflow (status: 0x2, task ID: 0x0, object ID: 0x3006146C)
  issue has been raised to Mbed OS on this.
Issues are documented in the README.md changes.
@JanneKiiskila
Copy link
Contributor Author

Network problems, K64F can't get a MAC;

18:37:16 18:37:15.611 | DS     Thread-7: [{u'payload': u'{}'}]
18:37:58 18:37:57.853 | D1 <<< DutThread: [EasyConnect] ERROR - No MAC address
18:37:58 18:37:57.855 | D1 <<< DutThread: [EasyConnect] Connection to Network Failed -3012!
18:37:58 18:37:57.855 | D1 <<< DutThread: Connection to Network Failed - exiting application...
18:40:14 
18:40:14.322 | TC     MainThread: Test Case fails because of: Timeout: Did not find registration message within 180 seconds
18:40:14 18:40:14.322 | TC     MainThread: ------TC END-----------
18:40:14 18:40:14.322 | TC     MainThread: TC FAIL

@JanneKiiskila
Copy link
Contributor Author

Re-run fixed it.

@MarceloSalazar
Copy link
Contributor

Thanks for reporting.

issue has been raised to Mbed OS on this.

Can you share a link please?

@MarceloSalazar
Copy link
Contributor

ARMmbed/mbed-os#5640

teetak01
teetak01 approved these changes Dec 9, 2017
View reviewed changes
Copy link
Contributor

@teetak01 teetak01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should run shellcheck thorough the .sh script at some point. There are a few minor common issues.

README.md Outdated
``` bash
cp configs/wifi_rtw_v4.json mbed_app.json
<use your favourite editor to modify mbed_app.json for WiFi SSUD/Password>
mbed compile -m REALTEK_RTL8195AM -t <your_toolchain>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

-t <TOOLCHAIN>

to be inline with mbed-cli documentation https://github.com/armmbed/mbed-cli

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!

README.md Outdated

``` bash
cp configs/wifi_rtw_v4.json mbed_app.json
<use your favourite editor to modify mbed_app.json for WiFi SSUD/Password>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WIFI SSID

README.md -t <TOOLCHAIN>
066b4ac 
To bea aligned with `mbed-cli` as per review feedback from Teemu Takaluoma.
Fixed also a typo in the line above (SSUD -> SSID).
@JanneKiiskila
Copy link
Contributor Author

Rebased and force pushed the new one in.

@JanneKiiskila
Copy link
Contributor Author

https://www.shellcheck.net/ - pushed it there, no issues found.
I think we might have some missing quotation marks, but the board names nor compiler tool chains can't have any spaces in them.

@JanneKiiskila
Copy link
Contributor Author

JanneKiiskila commented Dec 9, 2017 •
edited
Loading

Ran it now also in the Ubuntu build machine;

jankii01@mbed-gw-build:~/mbed/mbed-os-example-client$ shellcheck build_all.sh -s bash
jankii01@mbed-gw-build:~/mbed/mbed-os-example-client$

No findings?

@JanneKiiskila JanneKiiskila merged commit 7188e33 into master Dec 9, 2017
@JanneKiiskila JanneKiiskila deleted the RTL8195AM branch December 9, 2017 10:36
Archcady
Archcady reviewed Dec 11, 2017
View reviewed changes
Copy link

@Archcady Archcady left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine, we shall review and fix all the issues ASAP.

@JanneKiiskila JanneKiiskila mentioned this pull request Dec 20, 2017
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Archcady Archcady Archcady left review comments

@teetak01 teetak01 teetak01 approved these changes

@JammuKekkonen JammuKekkonen Awaiting requested review from JammuKekkonen

@MarceloSalazar MarceloSalazar Awaiting requested review from MarceloSalazar

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@JanneKiiskila @MarceloSalazar @teetak01 @Archcady