-
Notifications
You must be signed in to change notification settings - Fork 171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add documentation for static events/queue #1147
Add documentation for static events/queue #1147
Conversation
99341ad
to
75ef998
Compare
Edit new section for precise language and to fix typos.
Edit new section, mostly for inclusion of articles and precise language.
Edit file, mostly for clarity.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please review my changes to make sure I didn't accidentally change the meaning of anything.
Updated example link |
@AnotherButler |
docs/api/rtos/EventQueue.md
Outdated
@@ -57,6 +57,12 @@ To do this, set the `mbed_app.json` configuration option `events.shared-dispatch | |||
|
|||
[![View code](https://www.mbed.com/embed/?url=https://os.mbed.com/teams/mbed_example/code/Shared_Events_2/)](https://os.mbed.com/teams/mbed_example/code/Shared_Events_2/file/154179bdc39d/main.cpp) | |||
|
|||
## Static EventQueue example: posting user allocated events to the static queue | |||
|
|||
Use static EventQueue to prevent your program failing due to queue memory exhaustion or to prevent dynamic memory allocation: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shouldn't it be prevent your program from failing
?
docs/api/rtos/UserAllocatedEvent.md
Outdated
|
||
## UserAllocatedEvent class reference | ||
|
||
[![View code](https://www.mbed.com/embed/?type=library)](https://os.mbed.com/docs/development/mbed-os-api-doxy/_event_8h_source.html) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why this link still goes to the Event
class in doxygen, should this be to UserAllocatedEvent
class ?
Add missing word, as requested in comments.
Point link to correct class, as requested in comments.
@jamesbeyond Good catches 👍 Does that look better? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! that looks good to me!
As soon as the example is approved and merged, I'll merge this PR. |
Fix broken link.
Fix broken link.
Fix broken link.
This PR contains documentation update to cover new features of EventQueue and UserAllocatedEvent classes (PR with the implementation ARMmbed/mbed-os#11342)
PR with code example ARMmbed/mbed-os-examples-docs_only#52