Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation for static events/queue #1147

Merged

Conversation

maciejbocianski
Copy link
Contributor

@maciejbocianski maciejbocianski commented Aug 30, 2019

This PR contains documentation update to cover new features of EventQueue and UserAllocatedEvent classes (PR with the implementation ARMmbed/mbed-os#11342)

PR with code example ARMmbed/mbed-os-examples-docs_only#52

Amanda Butler added 3 commits September 3, 2019 13:45
Edit new section for precise language and to fix typos.
Edit new section, mostly for inclusion of articles and precise language.
Edit file, mostly for clarity.
Copy link
Contributor

@AnotherButler AnotherButler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please review my changes to make sure I didn't accidentally change the meaning of anything.

@maciejbocianski
Copy link
Contributor Author

Updated example link

@maciejbocianski
Copy link
Contributor Author

maciejbocianski commented Sep 4, 2019

@AnotherButler
LGTM

@jamesbeyond jamesbeyond changed the title [Work in progress] Add documentation for static events/queue Add documentation for static events/queue Sep 4, 2019
@@ -57,6 +57,12 @@ To do this, set the `mbed_app.json` configuration option `events.shared-dispatch

[![View code](https://www.mbed.com/embed/?url=https://os.mbed.com/teams/mbed_example/code/Shared_Events_2/)](https://os.mbed.com/teams/mbed_example/code/Shared_Events_2/file/154179bdc39d/main.cpp)

## Static EventQueue example: posting user allocated events to the static queue

Use static EventQueue to prevent your program failing due to queue memory exhaustion or to prevent dynamic memory allocation:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't it be prevent your program from failing ?


## UserAllocatedEvent class reference

[![View code](https://www.mbed.com/embed/?type=library)](https://os.mbed.com/docs/development/mbed-os-api-doxy/_event_8h_source.html)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why this link still goes to the Event class in doxygen, should this be to UserAllocatedEvent class ?

Amanda Butler added 2 commits September 4, 2019 10:59
Add missing word, as requested in comments.
Point link to correct class, as requested in comments.
@AnotherButler
Copy link
Contributor

@jamesbeyond Good catches 👍 Does that look better?

Copy link
Contributor

@jamesbeyond jamesbeyond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! that looks good to me!

@AnotherButler
Copy link
Contributor

As soon as the example is approved and merged, I'll merge this PR.

Amanda Butler added 3 commits September 5, 2019 10:15
@AnotherButler AnotherButler merged commit 90ed880 into ARMmbed:development Sep 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants