Update usage of PSA ITS to comply with v1.0 #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gilles-peskine-arm
previously approved these changes
Jan 24, 2019
There was a problem hiding this comment.
Looks ok by visual inspection. @Patater @dgreen-arm How do we validate the ITS support at the moment?
dgreen-arm
reviewed
Jan 25, 2019
|
@dgreen-arm Thanks |
dgreen-arm
previously approved these changes
Jan 25, 2019
dgreen-arm
approved these changes
Jan 28, 2019
|
ITS support is validated manually so far. Would be good to automate it. |
Patater
approved these changes
Jan 28, 2019
|
Test failures are the FreeBSD timing suites, which are known to be flaky. |
Yes, that's a good idea. Also good would be to get the ITS headers from a canonical location instead of maintaining our own copy. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.