Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"As-is" sorting ignores scores #346

Open
kirillt opened this issue Apr 18, 2023 · 2 comments
Open

"As-is" sorting ignores scores #346

kirillt opened this issue Apr 18, 2023 · 2 comments
Labels
bug Something isn't working

Comments

@kirillt
Copy link
Member

kirillt commented Apr 18, 2023

When "as-is" sorting is ON:

  • Switching direction or sorting between "ascending" and "descending" should not change order of resources with equal scores.
  • "Descending" should have top-scored resources on top.
  • "Ascending" should have top-scored resources in the end.
@kirillt kirillt added the bug Something isn't working label Apr 18, 2023
@shakeebularsalan
Copy link

@kirillt, Now it can’t be replicated. #412 is blocker for it.

@kirillt
Copy link
Member Author

kirillt commented Nov 6, 2023

@shakeebularsalan aggregated mode isn't needed to test this issue. Navigation to single folder must be enough.

Steps to reproduce:

  1. Open the app, add a folder with at least 2 resources.
  2. Tap the compass icon next to the folder.
  3. Resource Grid loads, turn "Scores" in tag selector ON.
  4. Tap any resource.
  5. Gallery view loads, there must be score widget (star and up/down arrows).
  6. Change the score using the arrows, e.g. +5.
  7. Swipe the resource to the next one.
  8. Change the score to e.g. +3.
  9. Go back to Resource Grid.

Any sorting must respect scores when they are turned ON. If "descending" order is selected (arrow near the dice icon points down), the resource with +5 score must always be before the resource with +3 score. In "ascending" order it must be the other way around.

  1. Try different sorting criterias, especially "as-is".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants