Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added multiple pick location on Location Based page #48

Closed
nicolocarpignoli opened this issue Apr 22, 2020 · 7 comments
Closed

Added multiple pick location on Location Based page #48

nicolocarpignoli opened this issue Apr 22, 2020 · 7 comments
Assignees
Labels

Comments

@nicolocarpignoli
Copy link
Member

nicolocarpignoli commented Apr 22, 2020

It should be possible to add more places on location based, following the Figma Design:

https://www.figma.com/file/TUjZ2KYsmhA5LUkt9KIhcB/ARjs-Studio?node-id=0%3A1

image

@nicolocarpignoli
Copy link
Member Author

From Design channel on Slack:

The idea was a location added in the map interface would automatically be added to the list above [the locations list], and a location with manually entered lat/long would automatically appear as a pin on the map...so in order to delete a pin you would find the corresponding number on the list and delete it from there.

@ba5eem
Copy link
Collaborator

ba5eem commented May 4, 2020

I started working on this - most functionality is there, adding multiple and removing, updating, deleting, etc. I need to fix some errors and add the labels to marker icons before PR ;also do a clean up on code.

@ba5eem ba5eem self-assigned this May 4, 2020
@nicolocarpignoli
Copy link
Member Author

@ba5eem Hi there! Any update on this one? :)

@ba5eem
Copy link
Collaborator

ba5eem commented May 18, 2020

Im close to done with it, just struggling with some state issues for multiple scenarios.

@nicolocarpignoli
Copy link
Member Author

Sorry to bother @ba5eem are you able to push this forward? I can help if you need assistance. 16th of June we have a presentation and everything should be done for the MVP :)
Let me know

@ba5eem
Copy link
Collaborator

ba5eem commented Jun 1, 2020

Not a bother at all, I totally have let the team down on this one. I worked on it some this weekend and decided maybe i should re-vamp it and figure the proper way to do this with shadow dom by following docs/guides etc., but its still proving to be a challenge for me. Good to know about the MVP - ill work on it more today and tomorrow, if I cant figure it out, help would be nice. Ill let you know ASAP.

@nicolocarpignoli
Copy link
Member Author

@ba5eem if you can take a look at the AR.js Studio Slack channel: technical-stuff it would be great :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants