Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RP Meeting - 2 November 2021 - Review of Sorghum Model #96

Open
sarahcleary opened this issue Sep 10, 2021 · 7 comments
Open

RP Meeting - 2 November 2021 - Review of Sorghum Model #96

sarahcleary opened this issue Sep 10, 2021 · 7 comments
Labels

Comments

@sarahcleary
Copy link
Contributor

Review of Sorghum Model - APSIMInitiative/ApsimX#572

@jbrider to present

@APSIMInitiative/reference-panel - Please let me know if you have suggestions for additional attendees. Meeting invite already sent to @JoeEyre; @uqschap7; @erik-van-oosterom. Please note new RP Reps - @rcichota and @femiguez

@APSIMInitiative/steering-committee - FYI. If you would like to attend, please let me know and I'll forward the meeting invitation.

Information for Developer

Upload the presentation at least a week prior to the meeting to the relevant issue - APSIMInitiative/ApsimX#572

Ideally presentation should be approximately 30 min

Model to be moved into “Under Review” and upload the Model Documentation to APSIM Next Generation

At the end of the meeting, it is anticipated that the AI RP will provide a list of tasks if complete will allow for the Model to move into Release and be available as part of the APSIM download.

Information for Reviewers

Please review presentation and the Model prior to the meeting.
Any key issues or relevant papers, please provide via this issue prior to the meeting for consideration by the Developer.

@sarahcleary
Copy link
Contributor Author

Moved to 14 December, starting at 9am (BNE time)

@jbrider
Copy link
Contributor

jbrider commented Dec 9, 2021

@APSIMInitiative/reference-panel
Just a quick note to say that I'm still working on the powerpoint presentation - hoping to have it uploaded on the weekend, but it may be as late as the morning of the presentation.

I've attached a quick screenshot of a comparison with one of the validation experiments from ApsimClassic. Most of the validation sets are just as close to the existing model.

image

@jbrider
Copy link
Contributor

jbrider commented Dec 14, 2021

@jbrider
Copy link
Contributor

jbrider commented Dec 14, 2021

Model is accepted and can be put into release once the following items are addressed:

  • autodocs updated and complete
  • upload plausibility simulations file
  • check CO2 response in plausibility simulation
  • update sowing parameters to include FertileTillerNumber instead of BudNumber
  • add example of using MicroClimate switch

Please add comments to this github issue if anything was missed.

@sarahcleary
Copy link
Contributor Author

If anyone would like a link to the recording of the review meeting, please send an email to [email protected]

@andynen
Copy link

andynen commented Mar 1, 2022

Hello there!

Please, when will the sorghum model be available?

Thank you

@jbrider
Copy link
Contributor

jbrider commented Mar 1, 2022

@andynen I have nearly got through the list of items to address. I'm hoping to put some time towards it later this week to finish off the remainder.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants