-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Crop Livestock Enterprise Model (CLEM) #3575
Comments
@lie112 - is this ready for RP (final) review? |
This version is ready for review and includes the requested example files and validation tests, Of course there are lots of things I am still working on, but this is ready to review. |
@APSIMInitiative/reference-panel - This is ready for your final review. Please note the updates including the example files and validation tests. CLEM_Example_Simulations:
CLEM HELP documentation:
CLEM_Example_Simulations.zip Any questions, please post here. |
@pre078 - CLEM Issue for your reference |
Running the example grazing simulation and i get the following warning Also the graphs of this simulation don't appear to be displaying properly but i think this is because the simulation is only running for a year rather than the 10 years that the clock is set too? |
There appears to be a file missing that is preventing me from running the crop growth sensibility simulation. it appears "Crop_new_format(Burkina 20130222).prn" is needed but is not in the zip files provided |
The CLEM grazing example works fine for me. |
Ah - it works fine for me as well from my compiled version. Throws an error when run from the installed version though, probably because the .prn file is being ignored by InnoSetup when we create the installer. |
Whats the solution Drew? |
@Keith-Pembleton - try upgrading to the most current release. I was able to replicate your "no conception details" problem with an older release, but the current one seems OK. |
I just had a look and the .prn file is actually included with the installed version, so that doesn't seem to be the problem. What's more, I've realised I copied the .apsimx file without copying the .prn file, which is why I was getting a failure. The upshot is that I'm not sure why it's not working for you. Did you open the .apsimx file by clicking 'open an example'? If so, then you would have saved the file somewhere else on your computer. You may need to also copy the .prn file into the same folder as the .apsimx file. Also, some extra files which Di wanted posted on this thread: |
@zur003 Eric I was running version 201.3.29.3669 (updated just before I started looking at it) and have just updated to 2019.4.9.3719, but still get the no conception details problem. Thoughts anyone? |
@hol430 Thanks Drew, the files you provided have allowed me to get the crop management crop growth sensibility simulation working. |
Yeah the CLEM grazing example still fails for me if I save it into a different folder:
It's the same problem as #3271 and #1783 - Apsim will get the path wrong after doing the following steps:
For the user, this means that you have to go to the weather node (or the file forage node for the CLEM example), and update the path to the file. |
@APSIMInitiative/reference-panel - does anyone have any further comments? |
A message box appears showing version number when browsing the tree - when clicking the Clem component. Is it supposed to be appearing in the messages tab? |
If the examples Crop File names are changed to use (eg) "%root%/Examples/CLEM/FileVegetables_Example2.prn", the simulation will work out of the box. In response to keith's request to "test clem": Overall - it's not clear whether the "product" is clem, or apsimx. A user runs the apsimx program, opens apsimx files, but the simulation contents have clem.zoneclem etc. In the lack of a plan to merge clem and apsim components, perhaps apsim & clem should be differentiated: (eg add a new file type .clem that is internally the same format)
|
I tried the example files and they worked fine for me. |
@pre078 - please note discussion above. |
@LouisAK - With reference to FileCrop display - we had turned this feature off as large datasets were slowing it down (ie. GRASP db files). We are re-thinking several options for linking in external data. Will update soon. |
@peter-devoil - Thanks for your comments - will wait for Adam Liedloff to reply to most of them. |
Hi everyone, |
@APSIMInitiative/reference-panel - Final decision to be made at July RP meeting. If you have any further issues, comments or questions, please raise them prior to this meeting. Thanks |
I looked at the two examples and they ran 'out of the box' (build 3878) so it is good to know that the file location issue has been fixed. I assume there is some 'proper' documentation for CLEM? This should be uploaded to the website and linked to under the category "Science Documentation" - as is there is not enough information for users. Then add a short blurb about the intent, approach, and basic assumptions (probably copied from the real documentation) and the link to the full documentation into the two examples. With that I think ready to go to release. (Note that I didn't try to create something from scratch - I think I would need that full doco to do that.) |
CLEM has full online documentation located at http://www.apsim.info/CLEM/Content/Home.htm |
So:
|
Done |
Information about help in CLEM is now in each example's information memo and will be updated in an upcoming pull from APSIMx. I don't know the syntax to include a clickable link in the memo. |
Haven't tested this, but pretty sure you can do this:
e.g.
|
Some CLEM users new to APSIMx are struggling to get examples working because they are opening them from the installed Examples/CLEM directory in C:\Program Files\APSIM2019.06.183947\Examples\CLEM with limited permissions. This causes the following issue |
Help URL and details now added to example memos. |
@sno036 - can you confirm this answers your concerns as raised above? |
I believe we usually we don't want users modifying the examples which are shipped with apsim. To run them, users should open them, save them to a new location, and then run them. |
I suggest APSIM doesn't allow users to run an example file form the examples directory. This would force new users to move them elsewhere rather than assume you can run them from where they are provided. A copy to folder function would be useful that copies the .apsimx file and all associated data files in the example directory. |
That is already how it works with examples. Yes I am happy for it to move to release. As with all the models, the doco will be under continuous improvement but this is fine to begin with. |
This is now in release |
CLEM is a whole-of-farm enterprise model that adopts the functionality of precursor models (Integrated Analysis Tool for smallholders, IAT and North Australia Beef Systems Analyser, NABSA) to provide a model that can test a range of farm improvement strategies in a multitude of crop and livestock enterprises while tracking impacts on finances, natural resources, and highly constrained resources such as labour. To achieve this, CLEM expands upon the approach at the core of IAT where available Resources or farm assets (e.g. animals, crops, fodder, labour, land, money, water) are used by farm Activities (e.g. grow crops, manage animals, feed animals, manage fodder, manage manure, feed household). The APSIM NG environment with graphical user interface and CLEM-specific additions provides a framework for the setup, parameterisation and control of this type of model. This will also allow for dynamic linkage between the whole farm model and APSIM crop models.
The text was updated successfully, but these errors were encountered: