Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

project might loose overflow #37

Open
APN-Pucky opened this issue Oct 18, 2024 · 1 comment · May be fixed by #39
Open

project might loose overflow #37

APN-Pucky opened this issue Oct 18, 2024 · 1 comment · May be fixed by #39

Comments

@APN-Pucky
Copy link
Owner

pb.set(cb.numEntries(), [cb.sumW(), cb.sumWY()], [cb.sumW2(), cb.sumWY2()])

should also carry over potential overflow

@APN-Pucky
Copy link
Owner Author

for pb, cb in zip(p.bins(), c.bins()):
should be bins(True), with Yoda_v2 padding of zeros as overflow

@APN-Pucky APN-Pucky linked a pull request Oct 18, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant