Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rethinkdb: FTBFS #2037

Closed
KexyBiscuit opened this issue Oct 17, 2019 · 3 comments
Closed

rethinkdb: FTBFS #2037

KexyBiscuit opened this issue Oct 17, 2019 · 3 comments
Labels
ftbfs Package fails to build from source help-wanted Help or suggestions needed

Comments

@KexyBiscuit
Copy link
Member

Bug description

    [23/441] CC build/release/obj/rdb_protocol/ql2.pb.o
/var/cache/acbs/build/acbs.xp_g158f/rethinkdb-2.3.7/drivers/javascript/errors.coffee:3:9: error: Can't reference 'this' before calling super in derived class constructors
        @name = @constructor.name
        ^
make[1]: *** [drivers/javascript/build.mk:25: build/drivers/javascript/coffee/errors.js] Error 1
make[1]: *** Deleting file 'build/drivers/javascript/coffee/errors.js'
make[1]: *** Waiting for unfinished jobs....

acbs-build_2_5en26i.log

Reproducing steps

Build rethinkdb.

Update channel(s)

Stable-Proposed

Package and version

b0d2b46

@KexyBiscuit KexyBiscuit added the ftbfs Package fails to build from source label Oct 17, 2019
@KexyBiscuit KexyBiscuit added this to the Fall 2019 milestone Oct 17, 2019
@LionNatsu
Copy link
Member

Here is more context of the code:

class ReqlError extends Error
    constructor: (msg, term, frames) ->
        @name = @constructor.name
        @msg = msg
        ...

The failure was because of the breaking changes in syntax from CoffeeScript 1.x to 2.0 http://coffeescript.org/v2/#breaking-changes-super-this and it is fundamentally because the new limitation in ES2015. Notations like @xxxx are the shorthand of this.xxxx and in CoffeeScript 2.0 it is not allowed before a super call.

Adding a single line can fix the problem:

class ReqlError extends Error
    constructor: (msg, term, frames) ->
        super
        @name = @constructor.name
        @msg = msg
        ...

But there are many such things in the code.

A simpler solution: (locally, if it's possible) downgrade coffeescript to 1.x.
But how?
cc: @liushuyu

@LionNatsu
Copy link
Member

@LionNatsu LionNatsu added the help-wanted Help or suggestions needed label Dec 26, 2019
@MingcongBai
Copy link
Member

We are dropping this package, no point maintaining a package that no one asked for. Open a package request if needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ftbfs Package fails to build from source help-wanted Help or suggestions needed
Projects
None yet
Development

No branches or pull requests

3 participants