Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Meta: Re-evaluate All PKGRECOM/PKGSUG #1918

Closed
3 tasks
MingcongBai opened this issue Jul 22, 2019 · 2 comments
Closed
3 tasks

Meta: Re-evaluate All PKGRECOM/PKGSUG #1918

MingcongBai opened this issue Jul 22, 2019 · 2 comments
Assignees
Labels
bug Topic/issue involves a bug enhancement Topic/issue involves an AOSC OS enhancement

Comments

@MingcongBai
Copy link
Member

Rationale

The current semantic interpretation of $PKGRECOM (Recommends) is something along the line of "soft dependency", which refers to package(s) that could enhance a package's functionalities if installed - and they are not installed automatically in our distribution, as specified in /etc/apt/apt.conf.d/99synaptic:

APT::Install-Recommends "false";

The issue stands that this semantic meaning should be given by $PKGSUG (Suggests) instead of "Recommends". Debian specifies in their Policy Manual that:

"This is used to declare that one package may be more useful with one or more others. Using this field tells the packaging system and the user that the listed packages are related to this one and can perhaps enhance its usefulness, but that installing this one without them is perfectly reasonable."

TL;DR: We have misused "Recommends" and "Suggests", time to get them fixed for good.

Plan of Action

  • Re-evaluate all $PKGRECOM and $PKGSUG in the tree.
    • Make some dependencies of the -base packages "Recommends", allowing for more user freedom.
  • Remove /etc/apt/apt.conf.d/99synaptic.

Branch and Timeframe

Explosive -> Testing, Summer 2019.

@MingcongBai MingcongBai added bug Topic/issue involves a bug dpkg enhancement Topic/issue involves an AOSC OS enhancement labels Jul 22, 2019
@MingcongBai MingcongBai self-assigned this Jul 22, 2019
@jyhi
Copy link
Member

jyhi commented Jul 23, 2019

Supplementary information:

Recommends

This declares a strong, but not absolute, dependency.

The Recommends field should list packages that would be found together with this one in all but unusual installations.

Suggests:

This is used to declare that one package may be more useful with one or more others. Using this field tells the packaging system and the user that the listed packages are related to this one and can perhaps enhance its usefulness, but that installing this one without them is perfectly reasonable.

-- https://www.debian.org/doc/debian-policy/ch-relationships.html#binary-dependencies-depends-recommends-suggests-enhances-pre-depends

@MingcongBai
Copy link
Member Author

Addressed with a batch job back in May, 2020 (for instance, 109176c). Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Topic/issue involves a bug enhancement Topic/issue involves an AOSC OS enhancement
Projects
None yet
Development

No branches or pull requests

3 participants