Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ament_export_targets in grid_map_costmap_2d (backport #424) #448

Merged
merged 3 commits into from
Feb 20, 2024

Conversation

mergify[bot]
Copy link

@mergify mergify bot commented Feb 20, 2024

This is an automatic backport of pull request #424 done by Mergify.


Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

* Link to exported namespace targets when possible

Signed-off-by: Ryan Friedman <[email protected]>
(cherry picked from commit c0c7ef1)
Signed-off-by: Ryan Friedman <[email protected]>
(cherry picked from commit fb02029)
Signed-off-by: Ryan Friedman <[email protected]>
(cherry picked from commit 8c3abed)
@Ryanf55 Ryanf55 merged commit e3fad51 into iron Feb 20, 2024
2 checks passed
@Ryanf55 Ryanf55 deleted the mergify/bp/iron/pr-424 branch February 20, 2024 14:24
@Ryanf55
Copy link
Collaborator

Ryanf55 commented Feb 20, 2024

CI missed a regression that the ROS build farm caught:

-- Generating done
CMake Generate step failed.  Build files cannot be regenerated correctly.
---
--- stderr: grid_map_costmap_2d
CMake Error at /opt/ros/iron/share/ament_cmake_gtest/cmake/ament_add_gtest_executable.cmake:50 (add_executable):
  Target "grid_map_costmap_2d-test" links to target
  "nav2_costmap_2d::nav2_costmap_2d_core" but the target was not found.
  Perhaps a find_package() call is missing for an IMPORTED target, or an
  ALIAS target is missing?
Call Stack (most recent call first):
  /opt/ros/iron/share/ament_cmake_gtest/cmake/ament_add_gtest_executable.cmake:37 (_ament_add_gtest_executable)
  /opt/ros/iron/share/ament_cmake_gtest/cmake/ament_add_gtest.cmake:68 (ament_add_gtest_executable)
  test/CMakeLists.txt:1 (ament_add_gtest)


CMake Error at /opt/ros/iron/share/ament_cmake_gtest/cmake/ament_add_gtest_executable.cmake:50 (add_executable):
  Target "costmap-2d-ros-test" links to target
  "nav2_costmap_2d::nav2_costmap_2d_core" but the target was not found.
  Perhaps a find_package() call is missing for an IMPORTED target, or an
  ALIAS target is missing?
Call Stack (most recent call first):
  /opt/ros/iron/share/ament_cmake_gtest/cmake/ament_add_gtest_executable.cmake:37 (_ament_add_gtest_executable)
  /opt/ros/iron/share/ament_cmake_gtest/cmake/ament_add_gtest.cmake:68 (ament_add_gtest_executable)
  test/CMakeLists.txt:10 (ament_add_gtest)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant