Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support for EB checkpoint files #59

Merged
merged 2 commits into from
Oct 5, 2022

Conversation

drangara
Copy link
Collaborator

@drangara drangara commented Aug 3, 2022

No description provided.

@WeiqunZhang
Copy link
Member

BuildFromChktFile takes optional arguments int ngrow=4 and bool extend_domain_face. I wonder if these two should be saved in checkpoint files and read from files instead. What would happen if the values passed to BuildFromChkFile don't match what were used originally?

@drangara
Copy link
Collaborator Author

That's right. I don't think it will work if ngrow on the finest level or extend_domain_face are different between the write and the read. I've now added the following settings when writing the checkpoint file - 1) problem hi & lo, 2) ngrow, 3) extend_domain_face, and 4) max_grid_size in ChkptFile::writeHeader. I've added asserts to make sure these settings are the same when reading from the checkpoint file in ChkptFile::read_from_chkpt_file. Hopefully that ensures we don't break implicitly.

@drangara drangara marked this pull request as ready for review September 7, 2022 18:17
@asalmgren asalmgren merged commit b0dce52 into AMReX-Fluids:development Oct 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants