Fix Matlab interface (diagnostics dimensions) #1447
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Got broken in #1438, because matlab and python have difference expectation on field lengths. Matlab expects values only for finite timepoints, python for all timepoints.
Codecov Report
@@ Coverage Diff @@
## develop #1447 +/- ##
========================================
Coverage 79.10% 79.11%
========================================
Files 66 66
Lines 10119 10139 +20
========================================
+ Hits 8005 8021 +16
- Misses 2114 2118 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
Kudos, SonarCloud Quality Gate passed!
|
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Got broken in #1438, because matlab and python have different expectation on field lengths.
Matlab expects values only for finite timepoints, python for all timepoints.