Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for sympy expressions for observables and sigmas #2568

Open
dweindl opened this issue Oct 24, 2024 · 0 comments
Open

Support for sympy expressions for observables and sigmas #2568

dweindl opened this issue Oct 24, 2024 · 0 comments

Comments

@dweindl
Copy link
Member

dweindl commented Oct 24, 2024

amici.sbml_import.SbmlImporter.sbml2amici currently expects expressions for observables/sigmas/... as strings. I think it would be preferable to (additionally) allow sympy expressions there, because it will resolve some potential ambiguities of expression strings.

Although not officially supported, it's already possible to do that. However, one has to make sure that the symbols used there have matching assumptions, otherwise this will easily result in hard-to-find model errors (often, only sensitivity equations will be affected). Ideally, for all free symbols, we would check that there is either no symbol with the same name in the model, or a symbol with the same name and same assumptions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant