Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Combine get_{expressions,observables,states,...}_as_dataframe? #2393

Open
dweindl opened this issue Apr 5, 2024 · 1 comment
Open

Combine get_{expressions,observables,states,...}_as_dataframe? #2393

dweindl opened this issue Apr 5, 2024 · 1 comment

Comments

@dweindl
Copy link
Member

dweindl commented Apr 5, 2024

Currently we have a number of get_*_as_dataframe functions. I think it would be convenient to have a function to get trajectories of all model entities from ReturnData, optionally filtered by a list of model entities.

I am not sure if this should (in the long term) replace, or be an addition to the current functions. Maintenance-wise, a single function would be preferable. Performance-wise, if one really only want to have all observables/state variables/expressions, individual functions may still make sense. I don't think the performance argument is really strong here, so I tend to rather replace the current functions, or temporarily implement them in terms of passing the respective entity IDs to a more general function.

@FFroehlich
Copy link
Member

fully agreed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants