Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to disable event-handling #2386

Open
dweindl opened this issue Mar 25, 2024 · 2 comments
Open

Option to disable event-handling #2386

dweindl opened this issue Mar 25, 2024 · 2 comments
Labels
c++ enhancement events related to handing discrete events SBML SBML import related

Comments

@dweindl
Copy link
Member

dweindl commented Mar 25, 2024

During preequilibration and presimulation, amici only handles events at t=t0, the others are ignored. For debugging preequilibration failures, it would be convenient if one could switch off event handling also for regular simulations. The alternative would be re-importing the model without events, which is often inconvenient.

@dweindl dweindl added enhancement c++ SBML SBML import related labels Mar 25, 2024
@dweindl dweindl added the events related to handing discrete events label Apr 21, 2024
@dweindl
Copy link
Member Author

dweindl commented Jun 17, 2024

For PEtab 2.0 we will require events to be processed during preequilibration. For PEtab 1.0, this wasn't explicitly specified, but there wasn't really a reason to assume that they should not be processed. Therefore, amici's non-event-handling could be considered a bug.
If we want to keep backward compatibility, we'll have to add such an option to enable/disable event processing.
However, I think, it would be less surprising, and thus, preferable to change the default. I am not sure how many users were aware of events not being processed during preequilibration.

@FFroehlich
Copy link
Member

sounds fair

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c++ enhancement events related to handing discrete events SBML SBML import related
Projects
None yet
Development

No branches or pull requests

2 participants