Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

requirements sympy >= 1.7 #1355

Closed
jvanhoefer opened this issue Dec 8, 2020 · 1 comment · Fixed by #1356
Closed

requirements sympy >= 1.7 #1355

jvanhoefer opened this issue Dec 8, 2020 · 1 comment · Fixed by #1356

Comments

@jvanhoefer
Copy link
Contributor

just a minor thing, but the newest AMICI version seems to need simply version 1.7, with 1.6.1 I got an ImportError for import amici in

AMICI/python/amici/ode_export.py

Line 34 in 275e599

from sympy.printing.codeprinter import cxxcode

However, sympy >= 1.7 seems to be not in the requirements (at least pip didn't automatically upgrade, when installing the newest AMICI...)
@jvanhoefer jvanhoefer added the new Newly created label Dec 8, 2020
@lcontento
Copy link
Contributor

In SymPy 1.6 cxxcode is in sympy.printing.cxxcode. But it should be sufficient to import it from sympy.printing which should work with both versions. Will make a small PR.

@lcontento lcontento mentioned this issue Dec 8, 2020
Merged
@dweindl dweindl linked a pull request Dec 9, 2020 that will close this issue
Fix cxxcode import for SymPy 1.6 (fixes #1355) #1356
Merged
@dweindl dweindl removed the new Newly created label Dec 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix cxxcode import for SymPy 1.6 (fixes #1355) AMICI-dev/AMICI
4 participants
@FFroehlich @lcontento @dweindl @jvanhoefer