Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PySB-petab is not respecting observable transformation or noise model #1339

Closed
FFroehlich opened this issue Nov 21, 2020 · 1 comment · Fixed by #1360
Closed

PySB-petab is not respecting observable transformation or noise model #1339

FFroehlich opened this issue Nov 21, 2020 · 1 comment · Fixed by #1360
Assignees
Labels
bug PEtab PEtab-import related PySB PySB import related

Comments

@FFroehlich
Copy link
Member

FFroehlich commented Nov 21, 2020

always assumes lin and normal, should probably raise an issue if thats not what the user requested.

@FFroehlich FFroehlich added the bug label Nov 21, 2020
@dweindl dweindl added PEtab PEtab-import related PySB PySB import related labels Nov 21, 2020
@dweindl
Copy link
Member

dweindl commented Nov 21, 2020

Agreed. I thought that was already the case. Related to #1176.

@dweindl dweindl self-assigned this Dec 10, 2020
@dweindl dweindl linked a pull request Dec 11, 2020 that will close this issue
dweindl added a commit that referenced this issue Dec 11, 2020
* Add support for different noise models for PySB import

.. as already the case for SBML import.

Closes #1176

* Respect noise model selection for PySB-PEtab import (#1339)

* doc, import

* Respect observable transformation for PySB-PEtab import (Fixes #1339)

* Set ODEModel._has_quadratic_nllh

Co-authored-by: Fabian Fröhlich <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug PEtab PEtab-import related PySB PySB import related
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants