Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure Python Wheel contains all that's needed #290

Closed
scy opened this issue Dec 15, 2024 · 2 comments
Closed

Make sure Python Wheel contains all that's needed #290

scy opened this issue Dec 15, 2024 · 2 comments
Assignees
Labels
area:backend Related to the server component area:orga Organizational & management prio:B Major impact, but not essential type:enhancement New feature or request

Comments

@scy
Copy link
Collaborator

scy commented Dec 15, 2024

The Wheel we're building as part of the GitHub Actions CI run should include everything required to run DearMEP. In other words:

  • the backend
  • the frontend
  • default configs
  • database migrations

Not included are:

  • dependencies (i.e. other Python packages that can be installed via the package manager)
  • a list of MEPs (third-party users should select these themselves)
  • name audio & MEP portraits (we don't have permission to redistribute them, third-party users need to download these themselves)
  • IVR audio and group logos (should be distributed in some other way, see Provide IVR audio & group logos #272)

I'd especially like to know if the database migrations work out of the box.

@scy scy added type:enhancement New feature or request area:backend Related to the server component prio:B Major impact, but not essential area:orga Organizational & management labels Dec 15, 2024
@scy scy added this to the 4.0: public release milestone Dec 15, 2024
@scy scy self-assigned this Dec 15, 2024
@scy
Copy link
Collaborator Author

scy commented Dec 27, 2024

The migrations weren't even included in the Wheel, and neither was the Alembic configuration. Added both in #304 and made it way easier to use.

@scy
Copy link
Collaborator Author

scy commented Dec 28, 2024

Wheel is looking good now, did a fresh setup based on it.

@scy scy closed this as completed Dec 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:backend Related to the server component area:orga Organizational & management prio:B Major impact, but not essential type:enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant