Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test and DRY functions that prepare representions of sets of values and probabilities (VAP sets) for UI #243

Open
4 tasks
AJamesPhillips opened this issue Mar 29, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@AJamesPhillips
Copy link
Owner

Currently

  • There are three main locations where the VAP set values are displayed in the UI:
    1. location 1: in the node view (value_and_prediction_summary) the "present" VAP set is shown (based on sim and created datetimes)
    2. location 2: on the component form under the component title the "present" VAP set is shown (based on sim and created datetimes)
    3. location 3: in the component form under "Value Predictions" a summary of each VAP set is shown
2024-03-15 VAP set value representations image 1
  • It is inefficient and harder to develop the code as there are multiple routes to achieve similar end results.

Description (acceptance criteria)

  • Having one test file that tests how a state wcomponent's VAP sets are prepared for presentation in the different locations of the UI.
  • The tests should include when a counterfactual is applied and when a state_value is in effect.
  • Refactor to the underlying code to use a DRYer set of functions to prepare this state.
  • Fix the current linting errors

Why (hypothesis)

Alternatives you've considered

None.

Additional context

Whilst trying to implement #241 it became apparent that invalid numbers where not being presented in an intelligible or consistent way #242 and that to implement #241 and #242 it would be easier if there was one function to extract state values from wcomponents or a specific VAP set, with or without counterfactuals already applied to it.

@AJamesPhillips AJamesPhillips added the enhancement New feature or request label Mar 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant