From 8ef2475827d9578652538718bdcb448229e6cae0 Mon Sep 17 00:00:00 2001 From: tmadlener Date: Thu, 12 Oct 2023 16:43:41 +0200 Subject: [PATCH] [wip] Bump pylint version to make tests pass --- .github/workflows/pre-commit.yml | 2 +- python/podio/test_ReaderRoot.py | 2 +- python/podio/test_utils.py | 3 ++- 3 files changed, 4 insertions(+), 3 deletions(-) diff --git a/.github/workflows/pre-commit.yml b/.github/workflows/pre-commit.yml index 70d60a73b..d22047cbf 100644 --- a/.github/workflows/pre-commit.yml +++ b/.github/workflows/pre-commit.yml @@ -25,7 +25,7 @@ jobs: # fails git config --global --add safe.directory $(pwd) pip install pre-commit - pip install pylint==2.12.2 + pip install pylint==2.17.7 pip install flake8 echo "::endgroup::" echo "::group::Run CMake" diff --git a/python/podio/test_ReaderRoot.py b/python/podio/test_ReaderRoot.py index e475a3c4d..c88d97e15 100644 --- a/python/podio/test_ReaderRoot.py +++ b/python/podio/test_ReaderRoot.py @@ -5,7 +5,7 @@ import unittest from test_Reader import ReaderTestCaseMixin, LegacyReaderTestCaseMixin # pylint: disable=import-error -from test_utils import LEGACY_DATA_AVAILABLE +from podio.test_utils import LEGACY_DATA_AVAILABLE from podio.root_io import Reader, LegacyReader diff --git a/python/podio/test_utils.py b/python/podio/test_utils.py index 9ef559100..e26d53b66 100644 --- a/python/podio/test_utils.py +++ b/python/podio/test_utils.py @@ -8,12 +8,13 @@ ROOT.gSystem.Load("libTestDataModelDict.so") # noqa: E402 from ROOT import ExampleHitCollection, ExampleClusterCollection # noqa: E402 # pylint: disable=wrong-import-position -from podio import Frame # pylint: disable=wrong-import-position +from .frame import Frame # pylint: disable=wrong-import-position SKIP_SIO_TESTS = os.environ.get("SKIP_SIO_TESTS", "1") == "1" LEGACY_DATA_AVAILABLE = os.environ.get("PODIO_TEST_INPUT_DATA_DIR", None) is not None + def create_hit_collection(): """Create a simple hit collection with two hits for testing""" hits = ExampleHitCollection()