-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(docker): revert CMD #517
Conversation
You can ignore the linter for now, just need to ensure that statutory is running again |
## [1.6.9](1.6.8...1.6.9) (2021-03-13) ### Bug Fixes * **docker:** revert CMD ([#517](#517)) ([8094534](8094534))
🎉 This PR is included in version 1.6.9 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
@@ -23,6 +23,6 @@ RUN npm install -g [email protected] | |||
RUN npm cache clean --force | |||
RUN npm install | |||
|
|||
CMD ["sh", "-c", "/usr/app/scripts/bootstrap.sh && nodemon -e 'js,json' lib/run.js"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, running it like this works on my local server (not my laptop, but a Ubuntu server with no vagrant). Even after removing the files and the container and rebuilding it from the start. Any ideas on how to test this properly? @serge1peshcoff
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no idea unfortunately, we can deploy once more and check if it works
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would be surprised if that works, but we can try. Can you deploy tag 1.6.8?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just checked, it doesn't fix it somehow
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But 1.6.9 does work? I reverted the CMD there
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, just checked, this works
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, so this change breaks stuff. @linuxbandit do you have any clue why? The code on the left gives a 'permission denied' error, but the code on the right works. Shouldn't they be executed by the same user?
No description provided.