fix(circleci): add new checks attempt 2 #486
Conversation
Codecov Report
@@ Coverage Diff @@
## master #486 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 38 38
Lines 1877 1877
Branches 342 342
=========================================
Hits 1877 1877
Continue to review full report at Codecov.
|
|
|
||
| CMD sh /usr/app/scripts/bootstrap.sh && nodemon -e "js,json" lib/run.js | ||
| CMD ["sh", "-c", "/usr/app/scripts/bootstrap.sh && nodemon -e 'js,json' lib/run.js"] |
There was a problem hiding this comment.
I'm unsure if it will work that way, can you double check?
There was a problem hiding this comment.
If I rebuild statutory locally, that should be enough for testing right? Or is there a better way to test it?
There was a problem hiding this comment.
rebuilding + starting (which is more important IMO, as we should validate it's indeed starting the app) should be fine I guess
There was a problem hiding this comment.
Of course the starting. It's running fine locally after rebuilding. But if you could test it out as well that would be nice
And rebased the PR on master again
|
@serge1peshcoff with the new Agora season and the hackathon coming up I would like to deploy this. Then I can also work on doing the same stuff to the other modules |
## [1.6.7](1.6.6...1.6.7) (2021-03-13) ### Bug Fixes * **circleci:** add new checks attempt 2 ([#486](#486)) ([27dbd6f](27dbd6f))
|
🎉 This PR is included in version 1.6.7 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Only new change is that I've removed the nodemon from the Dockerfile CMD. It should already be executed in dev because of the docker-compose.dev.yml