Update perturbIC.py #5

leoberhelman · 2024-10-16T03:26:09Z

This is a draft of a pull request to keep track of comments and questions I will have during refactoring and testing. Nothing yet but I am creating my unit tests.

Can the random generator be simplified?

src/perturbIC.py

…er functions. The descriptions are still in progress.

MartinDix · 2024-10-23T01:43:35Z

I can't work out why I specified it this way. In any case RandomState is no longer the recommended generator and the more up to date way of doing it would be

from numpy.random import Generator, PCG64
rg = Generator(PCG64(seed))
.. .rg.random(...)

This will give different results to the current implementation but will be stable in the future. PCG64 is currently the default bit generator but that could change so it's used explicitly here.

Added more documentation and created variables for the integers

Adding the pytests

Create the necessary environments for testing for 3.10

Create the environment for Python 3.11

…mp.py

…_validate_stdnames.py

…on.py

Co-authored-by: Davide Marchegiani <[email protected]>

Minor comments Co-authored-by: Davide Marchegiani <[email protected]>

Co-authored-by: Davide Marchegiani <[email protected]>

Random seed but need to discuss more about how to restrict parameters Co-authored-by: Davide Marchegiani <[email protected]>

Update perturbIC.py

577fc36

leoberhelman requested review from MartinDix, atteggiani and heidinett October 16, 2024 03:26

leoberhelman self-assigned this Oct 16, 2024

leoberhelman linked an issue Oct 16, 2024 that may be closed by this pull request

Requirements for perturbIC.py #4

Open

Update perturbIC.py

f9303f9

Can the random generator be simplified?

leoberhelman commented Oct 16, 2024

View reviewed changes

src/perturbIC.py Outdated Show resolved Hide resolved

Refactored changes to the perturbIC. Most of the code is not in small…

30b6c2d

…er functions. The descriptions are still in progress.

leoberhelman added 20 commits October 24, 2024 12:14

Update perturbIC.py

1d93ff4

Added more documentation and created variables for the integers

Create github-actions-demo.yml

3e04572

Create perturbIC_test.py

a5c35d8

Adding the pytests

Rename github-actions-demo.yml to unit_testing_umfile_utils.yml

7b3843a

Update unit_testing_umfile_utils.yml

a83735d

Create environment-3.10.yml

1eabd80

Create the necessary environments for testing for 3.10

Create environment-3.11.yml

235f1b2

Create the environment for Python 3.11

Update unit_testing_umfile_utils.yml

ef81e62

Update environment-3.11.yml

5509a7d

Update environment-3.10.yml

2cb666e

Create setup.py

c0f82b2

Create versioneer.py

5807ec4

Create pyproject.toml

336487e

Update perturbIC_test.py

3b0b9ce

Update perturbIC_test.py

4063e62

Create __init__.py

e70b6aa

Update unit_testing_umfile_utils.yml

b19d649

Update unit_testing_umfile_utils.yml

5d25b21

Update pyproject.toml

ce1de28

Update unit_testing_umfile_utils.yml

cc0e734

leoberhelman and others added 30 commits November 20, 2024 14:22

Rename src/um_fieldsfile_dump.py to src/umfile_utils/um_fieldsfile_du…

fdd7622

…mp.py

Rename src/sstice_ancil.py to src/umfile_utils/sstice_ancil.py

58075b4

Rename src/um2netcdf4_cmip6.py to src/umfile_utils/um2netcdf4_cmip6.py

6576b82

Rename src/stashvar_validate_stdnames.py to src/umfile_utils/stashvar…

f2c8f94

…_validate_stdnames.py

Rename src/stashvar_cmip6.py to src/umfile_utils/stashvar_cmip6.py

89894da

Rename src/subset_ancillary.py to src/umfile_utils/subset_ancillary.py

72bec1d

Rename src/split_times.py to src/umfile_utils/split_times.py

ce6d43e

Rename src/um2netcdf4.py to src/umfile_utils/um2netcdf4.py

6a90fc0

Rename src/subset_dump.py to src/umfile_utils/subset_dump.py

c7c3de4

Rename src/um2netcdf4_dev.py to src/umfile_utils/um2netcdf4_dev.py

acfcaa4

Rename src/um2netcdf.py to src/umfile_utils/um2netcdf.py

75412e3

Rename src/um_fileheaders.py to src/umfile_utils/um_fileheaders.py

3117e0e

Rename src/um_modify_field.py to src/umfile_utils/um_modify_field.py

21863fd

Rename src/um2netcdf_all.py to src/umfile_utils/um2netcdf_all.py

96779dd

Rename src/um_grid_flip.py to src/umfile_utils/um_grid_flip.py

a93c879

Rename src/umv2reg.py to src/umfile_utils/umv2reg.py

2fdb6f7

Rename src/valid_times.py to src/umfile_utils/valid_times.py

9f7a925

Rename src/um_zero_field.py to src/umfile_utils/um_zero_field.py

4d1a58e

Rename src/umv2netcdf.py to src/umfile_utils/umv2netcdf.py

cae40db

Rename src/um_replace_field.py to src/umfile_utils/um_replace_field.py

62d4e03

Rename src/um2netcdf_iris.py to src/umfile_utils/um2netcdf_iris.py

85fffd4

Rename src/um2netcdf_iris_mon.py to src/umfile_utils/um2netcdf_iris_m…

7d24615

…on.py

Rename src/umfile.py to src/umfile_utils/umfile.py

2029b8c

Create _version.py

3c3c779

Apply suggestions from code review

edec6c1

Co-authored-by: Davide Marchegiani <[email protected]>

Update __init__.py

9312f3a

Rename src/umfile_utils/perturbIC.py to src/perturbIC.py

3693bc4

Apply suggestions from code review

b4238c7

Minor comments Co-authored-by: Davide Marchegiani <[email protected]>

Update src/perturbIC.py

a8b0fe6

Co-authored-by: Davide Marchegiani <[email protected]>

Update src/perturbIC.py

13f5bc6

Random seed but need to discuss more about how to restrict parameters Co-authored-by: Davide Marchegiani <[email protected]>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update perturbIC.py #5

Update perturbIC.py #5

leoberhelman commented Oct 16, 2024

MartinDix commented Oct 23, 2024

Update perturbIC.py #5

Are you sure you want to change the base?

Update perturbIC.py #5

Conversation

leoberhelman commented Oct 16, 2024

MartinDix commented Oct 23, 2024