Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bladder 1 issues #228

Closed
4 tasks done
rchristie opened this issue Jul 3, 2023 · 5 comments · Fixed by #233
Closed
4 tasks done

Bladder 1 issues #228

rchristie opened this issue Jul 3, 2023 · 5 comments · Fixed by #233

Comments

@rchristie
Copy link
Member

rchristie commented Jul 3, 2023

Issues with bladder1 (with material coordinates) not addressed by PR #206

  • Rat bladder is stretched in dorsal-ventral direction. Seems to be incorrect compared to bladder with urethra1.
  • Change all models to be approximately unit sized; make central path have centre of urethra junction at 0,0,0, with urethra pointing in -y.
  • Comment out flat coordinates as flat fitting is now effective. (Also isn’t a good representation for cat which is narrower nearer to urethra).
  • Add bladder1 tests. Currently only testing bladder with urethra.
This was referenced Jul 3, 2023
@zekh167
Copy link
Contributor

zekh167 commented Jul 4, 2023

Hi Richard.
Regarding the second comment, the central path for all species is already on x-y plane and the center of urethra junction placed at (0,0,0) with urethra pointing in almost -x. Why you prefer to have the urethra pointing to -y direction? What is the difference?

@zekh167
Copy link
Contributor

zekh167 commented Jul 4, 2023

The other point is that the bladder shape is almost the same in all species and the main difference is their dimensions. That is why I made the scaffolds in different sizes to better represent the difference between them. So, isn't it better to keep them in different sizes?
If you prefer to have them approximately in unite size, I can change the central path to make this, but then, all the scaffolds may look similar. Is it OK?

@zekh167
Copy link
Contributor

zekh167 commented Jul 4, 2023

I changed the last test_bladder file to only test the bladder. Then, created a new test file, named test_bladderurethra which testing bladder with urethra.

@zekh167
Copy link
Contributor

zekh167 commented Jul 5, 2023

I changed the central path for rat and human to make the shape better.

@zekh167
Copy link
Contributor

zekh167 commented Jul 5, 2023

I also commented out the flat coordinates as you suggested.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants