Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Marker points need separate material coordinates field #217

Closed
rchristie opened this issue Nov 2, 2022 · 1 comment
Closed

Marker points need separate material coordinates field #217

rchristie opened this issue Nov 2, 2022 · 1 comment
Labels
enhancement New feature or request

Comments

@rchristie
Copy link
Member

With increasing numbers of marker points being created with material coordinates it's been revealed that finding mesh locations for them is very slow.
This is because the FindMeshLocation algorithm is not using cached element ranges due to the material coordinates field being in a modified state.

This task aims to gain the expected speed by:

  1. Ending ChangeManager(fieldmodule) for the main scaffold before defining sub-element annotations.
  2. Defining marker points in a renamed defineFaceAnnotations() method.
  3. Using a different-named field for material coordinate on markers, e.g. "marker body coordinates" instead of "body coordinates" otherwise the element range cache would still not be used.
@rchristie rchristie added the enhancement New feature or request label Nov 2, 2022
@rchristie
Copy link
Member Author

Fixed by #216

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant