Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace .load(object) and .loadFile(filepath) by .merge(object || filepath) #4

Closed
A-312 opened this issue Mar 7, 2020 · 1 comment · Fixed by #8
Closed

Replace .load(object) and .loadFile(filepath) by .merge(object || filepath) #4

A-312 opened this issue Mar 7, 2020 · 1 comment · Fixed by #8

Comments

@A-312
Copy link
Owner

A-312 commented Mar 7, 2020

Merge is a better function name
@A-312
Copy link
Owner Author

A-312 commented Mar 7, 2020 

convict.merge = function (source) {
  if (typeof source === 'string')
    loadFile(source)
  else
    load(source)
}

Source: mozilla/node-convict#353 (comment)

@A-312 A-312 linked a pull request Mar 7, 2020 that will close this issue
Replace .load(object) and .loadFile(filepath) by .merge(object || filepath) #8
Merged
@A-312 A-312 closed this as completed Mar 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Replace .load(object) and .loadFile(filepath) by .merge(object || filepath) A-312/node-blueconfig
1 participant
@A-312