Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor glitch: missing print format placeholder. #503

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

lootch
Copy link

@lootch lootch commented May 11, 2021

No description provided.

@lootch
Copy link
Author

lootch commented May 11, 2021

I guess I'd like to learn the ropes with something trivial, like adding a %d placeholder that clearly had been accidentally missed. There are three more tweaks, two of them purely cosmetic, lining up horizontal tabs instead of using spaces, mostly. The last one expands ssh-agent's capabilities beyond the present 2048-bit RSA key limit (I thought I'd mildly future proof the fix for up to 8192 bits, but I didn't have the stomach to try it: my equipment is too slow to generate such a key). I have been using 4096 a lot.

I'm planning to improve the docs for ssh-agent, but I thought I'd wait to see how the smaller tweaks would go down.

Lucio.

@0intro
Copy link
Member

0intro commented May 11, 2021

The change looks fine. Could you replace the commit message by something like "auth/ssh-agent: fix missing print format placeholder"? Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants