Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add gqlgen to awesome-go #749

Closed
Pokerkoffer opened this issue Jun 17, 2019 · 3 comments
Closed

Add gqlgen to awesome-go #749

Pokerkoffer opened this issue Jun 17, 2019 · 3 comments

Comments

@Pokerkoffer
Copy link

Pokerkoffer commented Jun 17, 2019

Hi,

i'd like to add this awesome library to awesome-go, a curated list of awesome golang libraries and tools. Personally, I use this list quite often to get an overview which libraries exist for a specific topic I want to implement.

They require some quality standards like test coverage and documentation for libraries to be added.

However, gocover.io reports an error when running: strconv.ParseFloat: parsing "": invalid syntax

Are you guys interested in adding this library to the list and look into the error? This can lead some new folk to this library and support development as well as some more attention, which is always good :)

I've read the docs about testing and you write that it isn't that easy to test generated code. Is it possible that the syntax error is occurring due to generated code?

PR: avelino/awesome-go#2566
Greetings

@vektah
Copy link
Collaborator

vektah commented Jun 18, 2019

code coverage over generated code is hard. I tried with coveralls but couldn't get it to exclude the generated code. No idea what gocover.io is doing though.

https://coveralls.io/github/99designs/gqlgen

I personally really dislike that golint rule XXX should have comment or be unexported. It leads to useless comments most of the time. At least golint excludes generated files.

@MichaelMure
Copy link
Contributor

FWIW, I get the exact same gocover error when trying on my project. Possibly because gqlgen is a dependency ?

@MichaelMure
Copy link
Contributor

Actually that seems to be a timeout on the gocover side ... https://github.com/vieux/gocover.io/issues/41

@vektah vektah mentioned this issue Jun 24, 2019
@vektah vektah closed this as completed Aug 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants